[lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature on

[lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature on

[Alistair John Strachan]

Enable driver checking of the DMI product name (when enabled) on
an Abit AT8 32X, instead of falling back to a manual probe. This
eliminates false negatives and eventually will help avoid
unnecessary bus probes on unsupported mainboards.

Signed-off-by: Alistair John Strachan <alistair@devzero.co.uk>
Tested-by: Daniel Exner <dex@dragonslave.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: lm-sensors@lm-sensors.org

---

 drivers/hwmon/abituguru3.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/abituguru3.c b/drivers/hwmon/abituguru3.c
index d568c65..8d43f3b 100644
--- a/drivers/hwmon/abituguru3.c
+++ b/drivers/hwmon/abituguru3.c
@@ -279,7 +279,7 @@ static const struct abituguru3_motherboard_info abituguru3_motherboards[] = {
 		{ "OTES1 Fan",		36, 2, 60, 1, 0 },
 		{ NULL, 0, 0, 0, 0, 0 } }
 	},
-	{ 0x0011, NULL /* Abit AT8 32X, need DMI string */, {
+	{ 0x0011, "AT8 32X(ATI RD580-ULI M1575)", {
 		{ "CPU Core",		 0, 0, 10, 1, 0 },
 		{ "DDR",		 1, 0, 20, 1, 0 },
 		{ "DDR VTT",		 2, 0, 10, 1, 0 },

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature

[Hans de Goede]

Alistair John Strachan wrote:
> Enable driver checking of the DMI product name (when enabled) on
> an Abit AT8 32X, instead of falling back to a manual probe. This
> eliminates false negatives and eventually will help avoid
> unnecessary bus probes on unsupported mainboards.
> 
> Signed-off-by: Alistair John Strachan <alistair@devzero.co.uk>
> Tested-by: Daniel Exner <dex@dragonslave.de>

Looks good,

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: lm-sensors@lm-sensors.org
> 
> ---
> 
>  drivers/hwmon/abituguru3.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/abituguru3.c b/drivers/hwmon/abituguru3.c
> index d568c65..8d43f3b 100644
> --- a/drivers/hwmon/abituguru3.c
> +++ b/drivers/hwmon/abituguru3.c
> @@ -279,7 +279,7 @@ static const struct abituguru3_motherboard_info abituguru3_motherboards[] = {
>  		{ "OTES1 Fan",		36, 2, 60, 1, 0 },
>  		{ NULL, 0, 0, 0, 0, 0 } }
>  	},
> -	{ 0x0011, NULL /* Abit AT8 32X, need DMI string */, {
> +	{ 0x0011, "AT8 32X(ATI RD580-ULI M1575)", {
>  		{ "CPU Core",		 0, 0, 10, 1, 0 },
>  		{ "DDR",		 1, 0, 20, 1, 0 },
>  		{ "DDR VTT",		 2, 0, 10, 1, 0 },
> 
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature

[Jean Delvare]

On Thu, 09 Oct 2008 09:47:10 +0200, Hans de Goede wrote:
> 
> 
> Alistair John Strachan wrote:
> > Enable driver checking of the DMI product name (when enabled) on
> > an Abit AT8 32X, instead of falling back to a manual probe. This
> > eliminates false negatives and eventually will help avoid
> > unnecessary bus probes on unsupported mainboards.
> > 
> > Signed-off-by: Alistair John Strachan <alistair@devzero.co.uk>
> > Tested-by: Daniel Exner <dex@dragonslave.de>
> 
> Looks good,
> 
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Queued up for 2.6.27, thanks.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature

[Alistair John Strachan]

Hi Jean,

On Thursday 09 October 2008 14:16:58 Jean Delvare wrote:
> Queued up for 2.6.27, thanks.

If you're taking hwmon patches, could you update MAINTAINERS in mainline to 
reflect this? Otherwise I would have CC'ed you and not Andrew directly.

-- 
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature

[Jean Delvare]

Hi Alistair,

On Thu, 9 Oct 2008 14:37:58 +0100, Alistair John Strachan wrote:
> Hi Jean,
> 
> On Thursday 09 October 2008 14:16:58 Jean Delvare wrote:
> > Queued up for 2.6.27, thanks.
> 
> If you're taking hwmon patches, could you update MAINTAINERS in mainline to 
> reflect this? Otherwise I would have CC'ed you and not Andrew directly.

There's nothing to update. I am not the hwmon subsystem maintainer. I
happen to pick fixes that have been properly reviewed and which I think
should be pushed upstream, but this is in no way official, and I may
stop doing it at any time depending on my workload and mood.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature

[Alistair John Strachan]

On Thursday 09 October 2008 14:43:44 Jean Delvare wrote:
> Hi Alistair,
>
> On Thu, 9 Oct 2008 14:37:58 +0100, Alistair John Strachan wrote:
> > Hi Jean,
> >
> > On Thursday 09 October 2008 14:16:58 Jean Delvare wrote:
> > > Queued up for 2.6.27, thanks.
> >
> > If you're taking hwmon patches, could you update MAINTAINERS in mainline
> > to reflect this? Otherwise I would have CC'ed you and not Andrew
> > directly.
>
> There's nothing to update. I am not the hwmon subsystem maintainer. I
> happen to pick fixes that have been properly reviewed and which I think
> should be pushed upstream, but this is in no way official, and I may
> stop doing it at any time depending on my workload and mood.

I see. Do you plan to sign off changes if you take them, or just pass them 
along?

-- 
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/2] abituguru3: enable DMI probing feature

[Jean Delvare]

On Thu, 9 Oct 2008 14:59:13 +0100, Alistair John Strachan wrote:
> On Thursday 09 October 2008 14:43:44 Jean Delvare wrote:
> > Hi Alistair,
> >
> > On Thu, 9 Oct 2008 14:37:58 +0100, Alistair John Strachan wrote:
> > > Hi Jean,
> > >
> > > On Thursday 09 October 2008 14:16:58 Jean Delvare wrote:
> > > > Queued up for 2.6.27, thanks.
> > >
> > > If you're taking hwmon patches, could you update MAINTAINERS in mainline
> > > to reflect this? Otherwise I would have CC'ed you and not Andrew
> > > directly.
> >
> > There's nothing to update. I am not the hwmon subsystem maintainer. I
> > happen to pick fixes that have been properly reviewed and which I think
> > should be pushed upstream, but this is in no way official, and I may
> > stop doing it at any time depending on my workload and mood.
> 
> I see. Do you plan to sign off changes if you take them, or just pass them 
> along?

I sign off everything that I pass along. You can see the list of the
patches I picked at:
  http://khali.linux-fr.org/devel/linux-2.6/jdelvare-hwmon/
(Updated every few days unless I'm too busy.)

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors