From: Brice Goglin <brice@myri.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: myri10ge: rename main file into myri10ge_main.c
Date: Thu, 09 Oct 2008 13:54:07 +0200 [thread overview]
Message-ID: <48EDF0DF.8020306@myri.com> (raw)
In-Reply-To: <20081008.162126.191961537.davem@davemloft.net>
David Miller wrote:
> I'm not applying this patch nor the one that does the
> actual split up.
>
> Single file drivers are so much easier to maintain and
> hack on, multi-file drivers are heavily discouraged.
>
> If I want to change some structure member in a multi-file
> driver I have go over seperate files instead of doing a
> single search and replace operation in a single editing
> buffer.
>
> Drivers like e1000, cxgb3 (especially cxgb3!) are such a pain
> in the ass to study and make changes to for this reason. Please
> don't add myri10ge to this group.
>
Oh, I wrongly thought people liked small pieces since most new drivers
come in multiple files these days.
So yeah, we're not splitting anymore :)
Brice
prev parent reply other threads:[~2008-10-09 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 23:21 myri10ge: rename main file into myri10ge_main.c David Miller
2008-10-09 11:54 ` Brice Goglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EDF0DF.8020306@myri.com \
--to=brice@myri.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.