* Re: myri10ge: rename main file into myri10ge_main.c
@ 2008-10-08 23:21 David Miller
2008-10-09 11:54 ` Brice Goglin
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2008-10-08 23:21 UTC (permalink / raw)
To: brice; +Cc: netdev
I'm not applying this patch nor the one that does the
actual split up.
Single file drivers are so much easier to maintain and
hack on, multi-file drivers are heavily discouraged.
If I want to change some structure member in a multi-file
driver I have go over seperate files instead of doing a
single search and replace operation in a single editing
buffer.
Drivers like e1000, cxgb3 (especially cxgb3!) are such a pain
in the ass to study and make changes to for this reason. Please
don't add myri10ge to this group.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: myri10ge: rename main file into myri10ge_main.c
2008-10-08 23:21 myri10ge: rename main file into myri10ge_main.c David Miller
@ 2008-10-09 11:54 ` Brice Goglin
0 siblings, 0 replies; 2+ messages in thread
From: Brice Goglin @ 2008-10-09 11:54 UTC (permalink / raw)
To: David Miller; +Cc: netdev
David Miller wrote:
> I'm not applying this patch nor the one that does the
> actual split up.
>
> Single file drivers are so much easier to maintain and
> hack on, multi-file drivers are heavily discouraged.
>
> If I want to change some structure member in a multi-file
> driver I have go over seperate files instead of doing a
> single search and replace operation in a single editing
> buffer.
>
> Drivers like e1000, cxgb3 (especially cxgb3!) are such a pain
> in the ass to study and make changes to for this reason. Please
> don't add myri10ge to this group.
>
Oh, I wrongly thought people liked small pieces since most new drivers
come in multiple files these days.
So yeah, we're not splitting anymore :)
Brice
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-09 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-08 23:21 myri10ge: rename main file into myri10ge_main.c David Miller
2008-10-09 11:54 ` Brice Goglin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.