Re: [PATCH] fix 3.3-testing c/s 18434

[Jim Fehlig <jfehlig@novell.com>]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Keir Fraser wrote:
> On 9/10/08 23:02, "Jim Fehlig" <jfehlig@novell.com> wrote:
>
>   
>> Missed that, sorry.
>>
>> I've also found that this c/s causes /local/domain/0/backend/{vkbd, vfb,
>> console} paths to leak :(.  Patch attached.
>>     
>
> A major point of the patch was to stop reading the backend link from the
> frontend directory.

Ah, right.  I should have looked at the patch more closely :-/

>  Is the problem that /vm/... is getting deleted too
> early? Could we delay it?
>   

Turns out that we were just constructing the path incorrectly.  Patch
attached.

Thanks,
Jim


    Signed-off-by: Jim Fehlig <jfehlig@novell.com>


[-- Attachment #2: xenstore-path.patch --]
[-- Type: text/x-patch, Size: 562 bytes --]

diff -r 39f6f421eac1 tools/python/xen/xend/server/DevController.py
--- a/tools/python/xen/xend/server/DevController.py	Fri Oct 10 10:15:58 2008 +0100
+++ b/tools/python/xen/xend/server/DevController.py	Fri Oct 10 13:04:54 2008 -0600
@@ -257,7 +257,7 @@ class DevController:
 
         if force:
             frontpath = self.frontendPath(dev)
-            backpath = self.readVm(devid, "backend")
+            backpath = self.readVm(dev, "backend")
             if backpath:
                 xstransact.Remove(backpath)
             xstransact.Remove(frontpath)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel