From: Eric Piel <eric.piel@tremplin-utc.net>
To: Pavel Machek <pavel@suse.cz>
Cc: lm-sensors@lm-sensors.org,
kernel list <linux-kernel@vger.kernel.org>,
Thomas Renninger <trenn@suse.de>, Tejun Heo <tj@kernel.org>,
Yan Burman <burman.yan@gmail.com>
Subject: Re: [lm-sensors] Accelerometer driver for HP laptops
Date: Wed, 15 Oct 2008 11:20:17 +0000 [thread overview]
Message-ID: <48F5D1F1.3060702@tremplin-utc.net> (raw)
In-Reply-To: <20081015105805.GD4247@atrey.karlin.mff.cuni.cz>
Pavel Machek schreef:
>
>> I've got already a changelog ready. Give me a couple of days to clean
>> things up and I'll send it to akpm myself :-)
>
> Ok, I'd like to help with cleaning... let me know if I can help some more.
Hi,
Thanks a lot for this patch.
>
> * whitelist hp2133
Great!
>
> * the driver has different name now.
That was too obvious for me to notice ;-)
>
> * remove /** from comments that are not linuxdoc compliant.
Hum... I'll try to fix the comments to make them linuxdoc compliant. I
must be missing something obvious, but do you know where is the doc
about linuxdoc?
>
> * remove /dev/accel. We can reintroduce it when it works
Right, that's probably the safest for now.
See you,
Eric
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Eric Piel <eric.piel@tremplin-utc.net>
To: Pavel Machek <pavel@suse.cz>
Cc: lm-sensors@lm-sensors.org,
kernel list <linux-kernel@vger.kernel.org>,
Thomas Renninger <trenn@suse.de>, Tejun Heo <tj@kernel.org>,
Yan Burman <burman.yan@gmail.com>
Subject: Re: Accelerometer driver for HP laptops
Date: Wed, 15 Oct 2008 13:20:17 +0200 [thread overview]
Message-ID: <48F5D1F1.3060702@tremplin-utc.net> (raw)
In-Reply-To: <20081015105805.GD4247@atrey.karlin.mff.cuni.cz>
Pavel Machek schreef:
>
>> I've got already a changelog ready. Give me a couple of days to clean
>> things up and I'll send it to akpm myself :-)
>
> Ok, I'd like to help with cleaning... let me know if I can help some more.
Hi,
Thanks a lot for this patch.
>
> * whitelist hp2133
Great!
>
> * the driver has different name now.
That was too obvious for me to notice ;-)
>
> * remove /** from comments that are not linuxdoc compliant.
Hum... I'll try to fix the comments to make them linuxdoc compliant. I
must be missing something obvious, but do you know where is the doc
about linuxdoc?
>
> * remove /dev/accel. We can reintroduce it when it works
Right, that's probably the safest for now.
See you,
Eric
next prev parent reply other threads:[~2008-10-15 11:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48C984F5.5000804@tudelft.nl>
[not found] ` <200809120736.06594.trenn@suse.de>
[not found] ` <48CAD89F.1050806@tremplin-utc.net>
2008-10-15 7:25 ` [lm-sensors] Accelerometer driver for HP laptops Pavel Machek
2008-10-15 7:25 ` Pavel Machek
2008-10-15 7:50 ` [lm-sensors] " Eric Piel
2008-10-15 7:50 ` Eric Piel
2008-10-15 10:58 ` [lm-sensors] " Pavel Machek
2008-10-15 10:58 ` Pavel Machek
2008-10-15 11:20 ` Eric Piel [this message]
2008-10-15 11:20 ` Eric Piel
2008-10-15 12:03 ` [lm-sensors] " Pavel Machek
2008-10-15 12:03 ` Pavel Machek
2008-10-16 9:10 ` [lm-sensors] Driver for HP harddisk protection LED Pavel Machek
2008-10-16 9:10 ` Pavel Machek
2008-10-16 22:55 ` [lm-sensors] " Andrew Morton
2008-10-16 22:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F5D1F1.3060702@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=burman.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pavel@suse.cz \
--cc=tj@kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.