All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brice Goglin <brice@myri.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: bzolnier@gmail.com, marek.vasut@gmail.com, tiwai@suse.de,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ralf@linux-mips.org,
	mark.fasheh@oracle.com, linuxppc-dev@ozlabs.org,
	linux-ide@vger.kernel.org, jesse.brandeburg@intel.com,
	akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
	dwmw2@infradead.org, David Miller <davem@davemloft.net>,
	mchehab@infradead.org
Subject: Re: powerpc allmodconfig
Date: Thu, 16 Oct 2008 08:55:08 +0200	[thread overview]
Message-ID: <48F6E54C.5010207@myri.com> (raw)
In-Reply-To: <1224137292.26782.5.camel@dwillia2-linux.ch.intel.com>

Dan Williams wrote:
> On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote:
>   
>>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
>>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
>>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
>>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
>>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
>>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
>>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
>>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
>>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'
>>>       
>> Known issue.  I tried to ping Jeff Garzik about doing a driver bug fix run in
>> order to fix this, but he hasn't shown any signs of life.
>>
>> So I'll do it myself later tonight. :-/
>>
>>     
> The following seems to fix this up...
>
> ---snip--->
> ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y
>   

There's already a completely different fix queued in netdev patchworks
(for myri10ge only right now, to be duplicated for Intel drivers). The
idea is to stop having almost-unrelated drivers select each other
directly, let people select which drivers they really want, and have
Kconfig handle modules/builtin-stuff correctly. See
http://patchwork.ozlabs.org/patch/4506/

Brice

WARNING: multiple messages have this Message-ID (diff)
From: Brice Goglin <brice@myri.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: David Miller <davem@davemloft.net>,
	akpm@linux-foundation.org, tiwai@suse.de,
	linux-ext4@vger.kernel.org, netdev@vger.kernel.org,
	linux-ide@vger.kernel.org, bzolnier@gmail.com,
	marek.vasut@gmail.com, dwmw2@infradead.org,
	mark.fasheh@oracle.com, ralf@linux-mips.org,
	mchehab@infradead.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	jesse.brandeburg@intel.com
Subject: Re: powerpc allmodconfig
Date: Thu, 16 Oct 2008 08:55:08 +0200	[thread overview]
Message-ID: <48F6E54C.5010207@myri.com> (raw)
In-Reply-To: <1224137292.26782.5.camel@dwillia2-linux.ch.intel.com>

Dan Williams wrote:
> On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote:
>   
>>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios':
>>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax'
>>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled':
>>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has'
>>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function)
>>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once
>>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.)
>>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
>>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id'
>>>       
>> Known issue.  I tried to ping Jeff Garzik about doing a driver bug fix run in
>> order to fix this, but he hasn't shown any signs of life.
>>
>> So I'll do it myself later tonight. :-/
>>
>>     
> The following seems to fix this up...
>
> ---snip--->
> ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y
>   

There's already a completely different fix queued in netdev patchworks
(for myri10ge only right now, to be duplicated for Intel drivers). The
idea is to stop having almost-unrelated drivers select each other
directly, let people select which drivers they really want, and have
Kconfig handle modules/builtin-stuff correctly. See
http://patchwork.ozlabs.org/patch/4506/

Brice


  reply	other threads:[~2008-10-16  6:55 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16  4:33 powerpc allmodconfig Andrew Morton
2008-10-16  4:33 ` Andrew Morton
2008-10-16  4:33 ` Andrew Morton
2008-10-16  4:33 ` Andrew Morton
2008-10-16  4:56 ` Benjamin Herrenschmidt
2008-10-16  4:56   ` Benjamin Herrenschmidt
2008-10-16 14:38   ` [PATCH] ibm_newemac: Fix new MAL feature handling Josh Boyer
2008-10-16 14:38     ` Josh Boyer
2008-10-17 12:56     ` Arnd Bergmann
2008-10-17 12:56       ` Arnd Bergmann
2008-10-17 13:09       ` Josh Boyer
2008-10-17 13:09         ` Josh Boyer
2008-10-20 23:43     ` Benjamin Herrenschmidt
2008-10-20 23:43       ` Benjamin Herrenschmidt
2008-10-21  5:17       ` Jeff Garzik
2008-10-21  5:17         ` Jeff Garzik
2008-10-16  5:02 ` powerpc allmodconfig David Miller
2008-10-16  5:02   ` David Miller
2008-10-16  6:08   ` Dan Williams
2008-10-16  6:08     ` Dan Williams
2008-10-16  6:55     ` Brice Goglin [this message]
2008-10-16  6:55       ` Brice Goglin
2008-10-16  6:58       ` David Miller
2008-10-16  6:58         ` David Miller
2008-10-16 16:22         ` Jesse Brandeburg
2008-10-16 16:22           ` Jesse Brandeburg
2008-10-16  7:31   ` Geert Uytterhoeven
2008-10-16  7:31     ` Geert Uytterhoeven
2008-10-16  7:36     ` David Miller
2008-10-16  7:36       ` David Miller
2008-10-16  7:58       ` Geert Uytterhoeven
2008-10-16  7:58         ` Geert Uytterhoeven
2008-10-16  7:53   ` Andreas Schwab
2008-10-16  7:53     ` Andreas Schwab
     [not found]   ` <20081015.220247.262683261.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-10-16  5:21     ` Benjamin Herrenschmidt
2008-10-16  5:21       ` Benjamin Herrenschmidt
2008-10-16  5:21       ` Benjamin Herrenschmidt
2008-10-16 14:57     ` Johannes Berg
2008-10-16 14:57       ` Johannes Berg
2008-10-16 14:57       ` Johannes Berg
     [not found]       ` <1224169039.735.57.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-10-16 19:49         ` David Miller
2008-10-16 19:49           ` David Miller
2008-10-16 19:49           ` David Miller
2008-10-16 20:02           ` Arjan van de Ven
2008-10-16 20:02             ` Arjan van de Ven
2008-10-18 12:20             ` Johannes Berg
2008-10-18 12:20               ` Johannes Berg
2008-10-17 11:09   ` Ingo Molnar
2008-10-17 11:09     ` Ingo Molnar
2008-10-17 11:09     ` Ingo Molnar
2008-10-17 11:09     ` Ingo Molnar
2008-10-16  5:57 ` Takashi Iwai
2008-10-16  5:57   ` Takashi Iwai
2008-10-16  7:38   ` Adrian Bunk
2008-10-16  7:38     ` Adrian Bunk
2008-10-16  7:57     ` Takashi Iwai
2008-10-16  7:57       ` Takashi Iwai
2008-10-16  8:21       ` Adrian Bunk
2008-10-16  8:21         ` Adrian Bunk
     [not found]         ` <20081016082157.GC23630-re2QNgSbS3j4D6uPqz5PAwR5/fbUUdgG@public.gmane.org>
2008-10-16  8:43           ` Takashi Iwai
2008-10-16  8:43             ` Takashi Iwai
2008-10-16  8:43             ` Takashi Iwai
     [not found]             ` <s5hod1lorpm.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2008-10-16 10:03               ` Adrian Bunk
2008-10-16 10:03                 ` Adrian Bunk
2008-10-16 10:03                 ` Adrian Bunk
2008-10-16  9:34 ` Mark Brown
2008-10-16  9:34   ` Mark Brown
2008-10-16 10:21 ` Sergei Shtylyov
2008-10-16 17:30   ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F6E54C.5010207@myri.com \
    --to=brice@myri.com \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.fasheh@oracle.com \
    --cc=mchehab@infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.