All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steven A. Falco" <sfalco@harris.com>
To: avorontsov@ru.mvista.com
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	i2c@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/7 RFC] Handle I2C GPIO controllers with the OF (was: pca9539 I2C gpio expander)
Date: Fri, 17 Oct 2008 12:07:15 -0400	[thread overview]
Message-ID: <48F8B833.7080807@harris.com> (raw)
In-Reply-To: <20081016171222.GA24812@oksana.dev.rtsoft.ru>

Anton Vorontsov wrote:
> Hi all,
> 
> Recently there was a question about I2C GPIO controllers and how should
> we handle them with the OpenFirmware and such.
> 
> Here is the attempt to "connect" I2C GPIO controllers to the
> "OpenFirmware" device tree, without writing an OF-specific bindings
> for each driver.
> 
> The salt is in these two patches:
> 
> [PATCH 3/7] of: fill the archdata for I2C devices
> ^ Here we're storing the device tree node into the I2C device.
> 
> [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls
> ^ And here we extracting the the stored node to put the registered
>   of_gpio_chip into that node.
> 
> 
> How does it look?

I've just tested this with a pca9539 chip attached to my Sequoia board,
and it works perfectly for me.  I don't have the mcu_mpc8349emitx.c file
in my tree, so I was not able to apply part 7 of 7, but the rest looks
fine.  Thanks for doing this.

Acked by: Steve Falco <sfalco@harris.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Steven A. Falco" <sfalco@harris.com>
To: avorontsov@ru.mvista.com
Cc: linux-kernel@vger.kernel.org,
	David Brownell <dbrownell@users.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Jean Delvare <khali@linux-fr.org>,
	David Miller <davem@davemloft.net>,
	i2c@lm-sensors.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 0/7 RFC] Handle I2C GPIO controllers with the OF (was: pca9539 I2C gpio expander)
Date: Fri, 17 Oct 2008 12:07:15 -0400	[thread overview]
Message-ID: <48F8B833.7080807@harris.com> (raw)
In-Reply-To: <20081016171222.GA24812@oksana.dev.rtsoft.ru>

Anton Vorontsov wrote:
> Hi all,
> 
> Recently there was a question about I2C GPIO controllers and how should
> we handle them with the OpenFirmware and such.
> 
> Here is the attempt to "connect" I2C GPIO controllers to the
> "OpenFirmware" device tree, without writing an OF-specific bindings
> for each driver.
> 
> The salt is in these two patches:
> 
> [PATCH 3/7] of: fill the archdata for I2C devices
> ^ Here we're storing the device tree node into the I2C device.
> 
> [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls
> ^ And here we extracting the the stored node to put the registered
>   of_gpio_chip into that node.
> 
> 
> How does it look?

I've just tested this with a pca9539 chip attached to my Sequoia board,
and it works perfectly for me.  I don't have the mcu_mpc8349emitx.c file
in my tree, so I was not able to apply part 7 of 7, but the rest looks
fine.  Thanks for doing this.

Acked by: Steve Falco <sfalco@harris.com>

  parent reply	other threads:[~2008-10-17 16:07 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 17:12 [PATCH 0/7 RFC] Handle I2C GPIO controllers with the OF (was: pca9539 I2C gpio expander) Anton Vorontsov
2008-10-16 17:12 ` Anton Vorontsov
2008-10-16 17:12 ` [PATCH 1/7] powerpc and sparc: introduce dev_archdata node accessors Anton Vorontsov
2008-10-16 17:12   ` Anton Vorontsov
2008-10-16 22:36   ` David Miller
2008-10-16 22:36     ` David Miller
2008-10-16 23:02     ` Grant Likely
2008-10-16 23:02       ` Grant Likely
2008-10-16 17:12 ` [PATCH 2/7] i2c: add info->archdata field Anton Vorontsov
2008-10-16 17:12   ` Anton Vorontsov
2008-10-17  9:21   ` Jean Delvare
2008-10-17  9:21     ` Jean Delvare
     [not found]     ` <20081017112125.1f2c9d94-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-10-22  0:27       ` Benjamin Herrenschmidt
2008-10-22  0:27         ` Benjamin Herrenschmidt
2008-10-22  0:27         ` Benjamin Herrenschmidt
2008-10-22  6:50         ` Jean Delvare
2008-10-22  6:50           ` Jean Delvare
2008-10-22  6:50           ` Jean Delvare
     [not found]           ` <20081022085002.0698e2a8-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-10-22  7:37             ` Benjamin Herrenschmidt
2008-10-22  7:37               ` Benjamin Herrenschmidt
2008-10-22  7:37               ` Benjamin Herrenschmidt
2008-10-22 10:08               ` Anton Vorontsov
2008-10-22 10:08                 ` Anton Vorontsov
2008-10-22 11:07                 ` Jean Delvare
2008-10-22 11:07                   ` Jean Delvare
2008-10-22 12:50                   ` Anton Vorontsov
2008-10-22 12:50                     ` Anton Vorontsov
     [not found] ` <20081016171222.GA24812-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-10-16 17:12   ` [PATCH 3/7] of: fill the archdata for I2C devices Anton Vorontsov
2008-10-16 17:12     ` Anton Vorontsov
2008-10-16 17:12     ` Anton Vorontsov
2008-10-22  4:14     ` Grant Likely
2008-10-22  4:14       ` Grant Likely
2008-10-16 17:12   ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add, remove} calls Anton Vorontsov
2008-10-16 17:12     ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls Anton Vorontsov
2008-10-16 17:12     ` Anton Vorontsov
2008-10-17 20:24     ` David Brownell
2008-10-17 20:24       ` David Brownell
2008-10-17 21:29       ` Anton Vorontsov
2008-10-17 21:29         ` Anton Vorontsov
2008-10-20  7:29         ` David Brownell
2008-10-20  7:29           ` David Brownell
2008-10-20 15:48           ` Anton Vorontsov
2008-10-20 15:48             ` Anton Vorontsov
     [not found]             ` <20081020154835.GA3234-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-10-22  0:29               ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add, remove} calls Benjamin Herrenschmidt
2008-10-22  0:29                 ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls Benjamin Herrenschmidt
2008-10-22  0:29                 ` Benjamin Herrenschmidt
2008-10-22  1:03                 ` Anton Vorontsov
2008-10-22  1:03                   ` Anton Vorontsov
2008-10-22  1:42                   ` Anton Vorontsov
2008-10-22  1:42                     ` Anton Vorontsov
     [not found]                     ` <20081022014243.GA19362-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-10-22  2:28                       ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add, remove} calls Benjamin Herrenschmidt
2008-10-22  2:28                         ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls Benjamin Herrenschmidt
2008-10-22  2:28                         ` Benjamin Herrenschmidt
2008-10-22  4:20                         ` Grant Likely
2008-10-22  4:20                           ` Grant Likely
2008-10-22  4:22                         ` David Brownell
2008-10-22  4:22                           ` David Brownell
2008-10-22 10:36                           ` Anton Vorontsov
2008-10-22 10:36                             ` Anton Vorontsov
2008-10-22 10:46                             ` Anton Vorontsov
2008-10-22 10:46                               ` Anton Vorontsov
2008-10-22 18:32                               ` Anton Vorontsov
2008-10-22 18:32                                 ` Anton Vorontsov
2008-10-22 21:04                                 ` David Brownell
2008-10-22 21:04                                   ` David Brownell
2008-10-22 21:22                                   ` Anton Vorontsov
2008-10-22 21:22                                     ` Anton Vorontsov
2008-10-22 21:52                                     ` David Brownell
2008-10-22 21:52                                       ` David Brownell
2008-10-22 22:29                                       ` Anton Vorontsov
2008-10-22 22:29                                         ` Anton Vorontsov
2008-10-23  5:19                                         ` David Brownell
2008-10-23  5:19                                           ` David Brownell
     [not found]                                   ` <200810221404.52798.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-10-23  4:45                                     ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add, remove} calls Benjamin Herrenschmidt
2008-10-23  4:45                                       ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls Benjamin Herrenschmidt
2008-10-23  4:45                                       ` Benjamin Herrenschmidt
2008-10-23  6:06                                       ` David Brownell
2008-10-23  6:06                                         ` David Brownell
2008-10-23  6:15                                 ` David Brownell
2008-10-23  6:15                                   ` David Brownell
2008-10-28 17:45                               ` [PATCH 0/6 RFC] OF-glue devices for I2C/SPI (was: " Anton Vorontsov
2008-10-28 17:45                                 ` Anton Vorontsov
2008-10-28 17:46                                 ` [PATCH 1/6] of/base: Add new helper of_should_create_pdev() Anton Vorontsov
2008-10-28 17:46                                 ` [PATCH 2/6] of/of_i2c: implement of_{,un}register_i2c_device Anton Vorontsov
2008-10-28 17:46                                 ` [PATCH 3/6] of/of_i2c: add support for dedicated OF I2C devices Anton Vorontsov
2008-10-28 18:41                                   ` David Miller
2008-10-28 17:46                                 ` [PATCH 4/6] of/gpio: add support for two-stage registration for the of_gpio_chips Anton Vorontsov
2008-10-28 17:46                                 ` [PATCH 5/6] gpio/pca953x: pass gpio_chip pointer to the setup/teardown callbacks Anton Vorontsov
2008-10-28 17:46                                 ` [PATCH 6/6] gpio: OpenFirmware bindings for the pca953x Anton Vorontsov
2008-10-28 17:53                                 ` [PATCH 0/6 RFC] OF-glue devices for I2C/SPI (was: Re: [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls Grant Likely
2008-10-28 17:53                                   ` [PATCH 0/6 RFC] OF-glue devices for I2C/SPI (was: Re: [PATCH 4/7] gpiolib: implement dev_gpiochip_{add, remove} calls Grant Likely
     [not found]                   ` <20081022010347.GA7377-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2008-10-22  2:27                     ` Benjamin Herrenschmidt
2008-10-22  2:27                       ` [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls Benjamin Herrenschmidt
2008-10-22  2:27                       ` Benjamin Herrenschmidt
2008-10-16 17:13 ` [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls Anton Vorontsov
2008-10-16 17:13   ` Anton Vorontsov
2008-10-17 20:25   ` David Brownell
2008-10-17 20:25     ` [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add, remove} calls David Brownell
2008-10-17 21:13     ` [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls Anton Vorontsov
2008-10-17 21:13       ` Anton Vorontsov
2008-10-17 21:13       ` Anton Vorontsov
2008-10-16 17:13 ` [PATCH 6/7] gpio/pca953x: convert to dev_gpiochip_add and make it work with the OF Anton Vorontsov
2008-10-16 17:13   ` Anton Vorontsov
2008-10-16 17:13 ` [PATCH 7/7] i2c/mcu_mpc8349emitx: convert to the new I2C/OF/GPIO infrastructure Anton Vorontsov
2008-10-16 17:13   ` Anton Vorontsov
2008-10-17 16:07 ` Steven A. Falco [this message]
2008-10-17 16:07   ` [PATCH 0/7 RFC] Handle I2C GPIO controllers with the OF (was: pca9539 I2C gpio expander) Steven A. Falco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F8B833.7080807@harris.com \
    --to=sfalco@harris.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=davem@davemloft.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.