From: "Andrew G. Morgan" <morgan@kernel.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
viro@zeniv.linux.org.ok, sgrubb@redhat.com, serue@us.ibm.com
Subject: Re: [PATCH 1/4] CAPABILITIES: add cpu endian vfs caps structure
Date: Mon, 20 Oct 2008 22:50:25 -0700 [thread overview]
Message-ID: <48FD6DA1.5030402@kernel.org> (raw)
In-Reply-To: <20081020222602.3895.77302.stgit@paris.rdu.redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Eric Paris wrote:
> This patch add a generic cpu endian caps structure and enternally available
> functions which retrieve fcaps information from disk. This information is
> necessary so fcaps information can be collected and recorded by the audit
> system.
>
[...]
> CAP_FOR_EACH_U32(i) {
> - __u32 value_cpu;
> -
> - if (i >= tocopy) {
> - /*
> - * Legacy capability sets have no upper bits
> - */
> - bprm->cap_post_exec_permitted.cap[i] = 0;
> + if (i > tocopy) {
Shouldn't the above still be (i >= tocopy) ?
Cheers
Andrew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFI/W2e+bHCR3gb8jsRAtDBAJ94XoCVXRDDycns4KEmLLBlYODiqACfUD7W
wx996Hso7mGH9lcc8Eiq89k=
=gx3P
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2008-10-21 5:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 22:25 [PATCH 0/4] Audit support for file capabilities Eric Paris
2008-10-20 22:25 ` Eric Paris
2008-10-20 22:26 ` [PATCH 1/4] CAPABILITIES: add cpu endian vfs caps structure Eric Paris
2008-10-20 22:26 ` Eric Paris
2008-10-21 5:50 ` Andrew G. Morgan [this message]
2008-10-21 13:22 ` Eric Paris
2008-10-21 13:22 ` Eric Paris
2008-10-20 22:26 ` [PATCH 2/4] AUDIT: output permitted and inheritable fcaps in PATH records Eric Paris
2008-10-20 22:26 ` Eric Paris
2008-10-20 22:26 ` [PATCH 3/4] AUDIT: audit when fcaps increase the permitted or inheritable capabilities Eric Paris
2008-10-20 22:26 ` Eric Paris
2008-10-21 5:53 ` Andrew G. Morgan
2008-10-21 19:16 ` Serge E. Hallyn
2008-10-21 19:16 ` Serge E. Hallyn
2008-10-22 12:51 ` Andrew G. Morgan
2008-10-22 14:14 ` Serge E. Hallyn
2008-10-22 14:14 ` Serge E. Hallyn
2008-10-23 4:13 ` Andrew G. Morgan
2008-10-29 21:58 ` Eric Paris
2008-10-29 21:58 ` Eric Paris
2008-10-30 13:35 ` Serge E. Hallyn
2008-10-30 13:35 ` Serge E. Hallyn
2008-10-20 22:26 ` [PATCH 4/4] AUDIT: emit new record type showing all capset information Eric Paris
2008-10-20 22:26 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD6DA1.5030402@kernel.org \
--to=morgan@kernel.org \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sgrubb@redhat.com \
--cc=viro@zeniv.linux.org.ok \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.