From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>,
Rusty Russell <rusty@rustcorp.com.au>,
davej@codemonkey.org.uk, Jeremy Fitzhardinge <jeremy@goop.org>,
Jes Sorensen <jes@sgi.com>, IA64 <linux-ia64@vger.kernel.org>,
S390 <linux-s390@vger.kernel.org>,
peterz@infradead.org, Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <dada1@cosmosbay.com>,
PowerPC <linuxppc-dev@ozlabs.org>,
Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
SPARC <sparclinux@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t
Date: Tue, 21 Oct 2008 12:28:43 +0000 [thread overview]
Message-ID: <48FDCAFB.3070802@sgi.com> (raw)
In-Reply-To: <20081021110925.853227d6.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Mike,
>
> Just a first small thing:
>
> On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@sgi.com> wrote:
>> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
>> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
>> 3) set_mask is set to either a single cpu or all online cpus in a policy.
>> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
>> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>>
>> From: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Mike Travis <travis@sgi.com>
>
> The From: line should be the first nonempty line in the mail to get the
> attribution correct.
>
Ahh, ok, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: davej@codemonkey.org.uk, Jeremy Fitzhardinge <jeremy@goop.org>,
Jes Sorensen <jes@sgi.com>, IA64 <linux-ia64@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
S390 <linux-s390@vger.kernel.org>,
peterz@infradead.org, David Miller <davem@davemloft.net>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, Eric Dumazet <dada1@cosmosbay.com>,
PowerPC <linuxppc-dev@ozlabs.org>,
Andi Kleen <andi@firstfloor.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
SPARC <sparclinux@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Jack Steiner <steiner@sgi.com>
Subject: Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage
Date: Tue, 21 Oct 2008 05:28:43 -0700 [thread overview]
Message-ID: <48FDCAFB.3070802@sgi.com> (raw)
In-Reply-To: <20081021110925.853227d6.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Mike,
>
> Just a first small thing:
>
> On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@sgi.com> wrote:
>> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
>> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
>> 3) set_mask is set to either a single cpu or all online cpus in a policy.
>> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
>> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>>
>> From: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Mike Travis <travis@sgi.com>
>
> The From: line should be the first nonempty line in the mail to get the
> attribution correct.
>
Ahh, ok, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: davej@codemonkey.org.uk, Jeremy Fitzhardinge <jeremy@goop.org>,
Jes Sorensen <jes@sgi.com>, IA64 <linux-ia64@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
S390 <linux-s390@vger.kernel.org>,
peterz@infradead.org, David Miller <davem@davemloft.net>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, Eric Dumazet <dada1@cosmosbay.com>,
PowerPC <linuxppc-dev@ozlabs.org>,
Andi Kleen <andi@firstfloor.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
SPARC <sparclinux@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Jack Steiner <steiner@sgi.com>
Subject: Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t
Date: Tue, 21 Oct 2008 12:28:43 +0000 [thread overview]
Message-ID: <48FDCAFB.3070802@sgi.com> (raw)
In-Reply-To: <20081021110925.853227d6.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Mike,
>
> Just a first small thing:
>
> On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@sgi.com> wrote:
>> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
>> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
>> 3) set_mask is set to either a single cpu or all online cpus in a policy.
>> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
>> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>>
>> From: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Mike Travis <travis@sgi.com>
>
> The From: line should be the first nonempty line in the mail to get the
> attribution correct.
>
Ahh, ok, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>,
Rusty Russell <rusty@rustcorp.com.au>,
davej@codemonkey.org.uk, Jeremy Fitzhardinge <jeremy@goop.org>,
Jes Sorensen <jes@sgi.com>, IA64 <linux-ia64@vger.kernel.org>,
S390 <linux-s390@vger.kernel.org>,
peterz@infradead.org, Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <dada1@cosmosbay.com>,
PowerPC <linuxppc-dev@ozlabs.org>,
Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
SPARC <sparclinux@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage
Date: Tue, 21 Oct 2008 05:28:43 -0700 [thread overview]
Message-ID: <48FDCAFB.3070802@sgi.com> (raw)
In-Reply-To: <20081021110925.853227d6.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Mike,
>
> Just a first small thing:
>
> On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@sgi.com> wrote:
>> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
>> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
>> 3) set_mask is set to either a single cpu or all online cpus in a policy.
>> Since it's just used for set_cpus_allowed(), any offline cpus in a policy
>> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>>
>> From: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>> Signed-off-by: Mike Travis <travis@sgi.com>
>
> The From: line should be the first nonempty line in the mail to get the
> attribution correct.
>
Ahh, ok, thanks!
next prev parent reply other threads:[~2008-10-21 12:28 UTC|newest]
Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:03 [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-21 0:09 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce Stephen Rothwell
2008-10-21 0:09 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage Stephen Rothwell
2008-10-21 0:09 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce Stephen Rothwell
2008-10-21 0:09 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage Stephen Rothwell
2008-10-21 12:28 ` Mike Travis [this message]
2008-10-21 12:28 ` Mike Travis
2008-10-21 12:28 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t Mike Travis
2008-10-21 12:28 ` [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage Mike Travis
2008-10-20 17:03 ` [PATCH 02/35] cpumask: remove min from first_cpu/next_cpu Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 03/35] cpumask: add for_each_cpu_mask_and function Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 04/35] x86 smp: modify send_IPI_mask interface to accept cpumask_t pointers Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 05/35] sched: Reduce stack size requirements in kernel/sched.c Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 06/35] cpumask: introduce struct cpumask Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 07/35] cpumask: change cpumask_scnprintf, cpumask_parse_user, cpulist_parse, and cpulist_scnp Mike Travis
2008-10-20 17:03 ` [PATCH 07/35] cpumask: change cpumask_scnprintf, cpumask_parse_user, cpulist_parse, and cpulist_scnprintf to take pointers Mike Travis
2008-10-20 17:03 ` [PATCH 07/35] cpumask: change cpumask_scnprintf, cpumask_parse_user, cpulist_parse, and cpulist_scnp Mike Travis
2008-10-20 17:03 ` [PATCH 07/35] cpumask: change cpumask_scnprintf, cpumask_parse_user, cpulist_parse, and cpulist_scnprintf to take pointers Mike Travis
2008-10-20 17:03 ` [PATCH 08/35] cpumask: cpumask_size() Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 09/35] cpumask: add cpumask_copy() Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 10/35] cpumask: introduce cpumask_var_t for local cpumask vars Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 11/35] x86: enable MAXSMP Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 12/35] cpumask: make CONFIG_NR_CPUS always valid Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 13/35] cpumask: use setup_nr_cpu_ids() instead of direct assignment Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 14/35] cpumask: make nr_cpu_ids valid in all configurations Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 15/35] cpumask: prepare for iterators to only go to nr_cpu_ids Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 16/35] percpu: fix percpu accessors to potentially !cpu_possible() cpus Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 17/35] cpumask: make nr_cpu_ids the actual limit on bitmap size Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 18/35] cpumask: add nr_cpumask_bits Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-21 12:26 ` Rusty Russell
2008-10-21 12:26 ` Rusty Russell
2008-10-21 12:26 ` Rusty Russell
2008-10-21 12:26 ` Rusty Russell
2008-10-21 13:53 ` Mike Travis
2008-10-21 13:53 ` Mike Travis
2008-10-21 13:53 ` Mike Travis
2008-10-21 13:53 ` Mike Travis
2008-10-20 17:03 ` [PATCH 19/35] cpumask: use cpumask_bits() everywhere Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 20/35] cpumask: cpumask_of(): cpumask_of_cpu() which returns a pointer Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 21/35] cpumask: for_each_cpu(): for_each_cpu_mask which takes " Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 22/35] cpumask: cpumask_first/cpumask_next Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 23/35] cpumask: deprecate any_online_cpu() in favour of cpumask_any/cpumask_any_and Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 24/35] cpumask: cpumask_any_but() Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 25/35] cpumask: Deprecate CPUMASK_ALLOC etc in favor of cpumask_var_t Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 26/35] cpumask: get rid of boutique sched.c allocations, use cpumask_var_t Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 27/35] cpumask: to_cpumask() Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 28/35] cpumask: accessors to manipulate possible/present/online/active maps Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 29/35] cpumask: Use accessors code Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 30/35] cpumask: CONFIG_BITS_ALL, CONFIG_BITS_NONE and CONFIG_BITS_CPU0 Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 31/35] cpumask: switch over to cpu_online/possible/active/present_mask Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 32/35] cpumask: cpu_all_mask and cpu_none_mask Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 33/35] cpumask: reorder header to minimize separate #ifdefs Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 34/35] cpumask: debug options for cpumasks Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` [PATCH 35/35] cpumask: smp_call_function_many() Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
2008-10-20 17:03 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FDCAFB.3070802@sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dada1@cosmosbay.com \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.