From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] pci: use pci_ioremap_bar() in drivers/ide
Date: Wed, 22 Oct 2008 21:40:37 +0400 [thread overview]
Message-ID: <48FF6595.5040203@ru.mvista.com> (raw)
In-Reply-To: <48FDA8BF.20206@ru.mvista.com>
Hello, I wrote:
>> Use the newly introduced pci_ioremap_bar() function in drivers/ide.
>> pci_ioremap_bar() just takes a pci device and a bar number, with the goal
>> of making it really hard to get wrong, while also having a central place
>> to stick sanity checks.
>> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
No, I'm takign back my ACK.
Since the patch intends to address all drivers/ide/, it's clearly no
compolete -- siimage.c and scc_pata.c beg for the alike change (it will even
permit to kill 4 local variables in the latter driver).
MBR, Sergei
next prev parent reply other threads:[~2008-10-22 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 4:48 [PATCH] pci: use pci_ioremap_bar() in drivers/ide Arjan van de Ven
2008-10-21 10:02 ` Sergei Shtylyov
2008-10-22 17:40 ` Sergei Shtylyov [this message]
2008-10-22 17:56 ` Arjan van de Ven
2008-10-22 18:08 ` Sergei Shtylyov
2008-10-22 20:23 ` Arjan van de Ven
2008-10-22 20:38 ` Sergei Shtylyov
2008-10-22 20:42 ` Sergei Shtylyov
2008-10-23 19:39 ` Bartlomiej Zolnierkiewicz
2008-10-23 19:35 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF6595.5040203@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=arjan@infradead.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.