Re: [PATCH] pci: use pci_ioremap_bar() in drivers/ide

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Arjan van de Ven wrote:

>>>>Use the newly introduced pci_ioremap_bar() function in drivers/ide.
>>>>pci_ioremap_bar() just takes a pci device and a bar number, with
>>>>the goal of making it really hard to get wrong, while also having
>>>>a central place to stick sanity checks.

>>>>Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

>>>Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

>>    No, I'm takign back my ACK.
>>    Since the patch intends to address all drivers/ide/, it's clearly
>>no compolete -- siimage.c and scc_pata.c beg for the alike change (it
>>will even permit to kill 4 local variables in the latter driver).

> I'll be happy to take a second pass, but "doesn't convert everyone"
> shouldn't really be a reason to do the first pass ;-)

    To not do, you mean?
    If you're going to leave this patch as it, it's worth to change the 
subject/header reflecting a modest goal of doing this only for one driver. ;-)

MBR, Sergei