From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] examples/ipsec-secgw: Calling risky function
Date: Tue, 7 Jun 2016 09:15:28 +0100 [thread overview]
Message-ID: <48bb7dd9-a8cb-167a-ce7c-868427be578b@intel.com> (raw)
In-Reply-To: <1465289886-14479-1-git-send-email-slawomirx.mrozowicz@intel.com>
On 07/06/2016 09:58, Slawomir Mrozowicz wrote:
> lrand48 should not be used for security related applications,
> as linear congruential algorithms are too easy to break.
> Used a compliant random number generator /dev/urandom.
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> Coverity ID 124558
>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> ---
I understand that lrand48 is not crypto secure, but this fix will kill
performance.
I already have a solution for this issue to be included in the next
IPSec patch set
that will also add support for GCM/CTR modes.
Sergio
next prev parent reply other threads:[~2016-06-07 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 8:58 [PATCH] examples/ipsec-secgw: Calling risky function Slawomir Mrozowicz
2016-06-07 8:11 ` Thomas Monjalon
2016-06-07 8:15 ` Sergio Gonzalez Monroy [this message]
2016-06-07 13:16 ` Mrozowicz, SlawomirX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48bb7dd9-a8cb-167a-ce7c-868427be578b@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.