From: Jeff Garzik <jeff@garzik.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, hch@lst.de, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: Fix typo in flow control config option
Date: Mon, 27 Oct 2008 14:52:42 -0400 [thread overview]
Message-ID: <49060DFA.7090901@garzik.org> (raw)
In-Reply-To: <20081024135314.GA2299@yoda.jdub.homelinux.org>
Josh Boyer wrote:
> The recent build fix for ibm_newemac has a typo in the config
> option #ifdef used for disabling flow control. This corrects
> it to the proper Kconfig option name.
>
> Reported-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> ---
>
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 2ee2622..901212a 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -2605,7 +2605,7 @@ static int __devinit emac_init_config(struct emac_instance *dev)
> of_device_is_compatible(np, "ibm,emac-440gr"))
> dev->features |= EMAC_FTR_440EP_PHY_CLK_FIX;
> if (of_device_is_compatible(np, "ibm,emac-405ez")) {
> -#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
> +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL
> dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
> #else
> printk(KERN_ERR "%s: Flow control not disabled!\n",
applied
prev parent reply other threads:[~2008-10-27 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 13:53 [PATCH] ibm_newemac: Fix typo in flow control config option Josh Boyer
2008-10-27 18:52 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49060DFA.7090901@garzik.org \
--to=jeff@garzik.org \
--cc=hch@lst.de \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.