* [PATCH][RESEND] tracing: fix a build error on alpha
@ 2008-10-28 8:43 Frederic Weisbecker
2008-10-28 8:53 ` Ingo Molnar
2008-11-13 22:52 ` Alexey Dobriyan
0 siblings, 2 replies; 5+ messages in thread
From: Frederic Weisbecker @ 2008-10-28 8:43 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Linux Kernel, Alexey Dobriyan
When tracing is enabled, some arch have included <linux/irqflags.h>
on their <asm/system.h> but others like alpha or m68k don't.
Build error on alpha:
kernel/trace/trace.c: In function 'tracing_cpumask_write':
kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable'
kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'
Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).
Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 306e433..c09493e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -34,6 +34,7 @@
#include <linux/stacktrace.h>
#include <linux/ring_buffer.h>
+#include <linux/irqflags.h>
#include "trace.h"
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][RESEND] tracing: fix a build error on alpha
2008-10-28 8:43 [PATCH][RESEND] tracing: fix a build error on alpha Frederic Weisbecker
@ 2008-10-28 8:53 ` Ingo Molnar
2008-11-13 22:52 ` Alexey Dobriyan
1 sibling, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2008-10-28 8:53 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Linux Kernel, Alexey Dobriyan
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> When tracing is enabled, some arch have included <linux/irqflags.h>
> on their <asm/system.h> but others like alpha or m68k don't.
>
> Build error on alpha:
>
> kernel/trace/trace.c: In function 'tracing_cpumask_write':
> kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable'
> kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'
>
> Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).
>
> Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
applied to tip/tracing/urgent, thanks Frederic!
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][RESEND] tracing: fix a build error on alpha
2008-10-28 8:43 [PATCH][RESEND] tracing: fix a build error on alpha Frederic Weisbecker
2008-10-28 8:53 ` Ingo Molnar
@ 2008-11-13 22:52 ` Alexey Dobriyan
2008-11-13 23:11 ` Ingo Molnar
2008-11-13 23:28 ` Frédéric Weisbecker
1 sibling, 2 replies; 5+ messages in thread
From: Alexey Dobriyan @ 2008-11-13 22:52 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Ingo Molnar, Linux Kernel
On Tue, Oct 28, 2008 at 11:43 AM, Frederic Weisbecker
<fweisbec@gmail.com> wrote:
> +#include <linux/irqflags.h>
Already fixed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][RESEND] tracing: fix a build error on alpha
2008-11-13 22:52 ` Alexey Dobriyan
@ 2008-11-13 23:11 ` Ingo Molnar
2008-11-13 23:28 ` Frédéric Weisbecker
1 sibling, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2008-11-13 23:11 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Frederic Weisbecker, Linux Kernel
* Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Tue, Oct 28, 2008 at 11:43 AM, Frederic Weisbecker
> <fweisbec@gmail.com> wrote:
> > +#include <linux/irqflags.h>
>
> Already fixed.
Note that it's already fixed because the patch you are replying to
(and which was sent 16 days ago) is already upstream:
21798a8: tracing: fix a build error on alpha
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][RESEND] tracing: fix a build error on alpha
2008-11-13 22:52 ` Alexey Dobriyan
2008-11-13 23:11 ` Ingo Molnar
@ 2008-11-13 23:28 ` Frédéric Weisbecker
1 sibling, 0 replies; 5+ messages in thread
From: Frédéric Weisbecker @ 2008-11-13 23:28 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Ingo Molnar, Linux Kernel
2008/11/13 Alexey Dobriyan <adobriyan@gmail.com>:
> On Tue, Oct 28, 2008 at 11:43 AM, Frederic Weisbecker
> <fweisbec@gmail.com> wrote:
>> +#include <linux/irqflags.h>
>
> Already fixed.
>
And you were even put on Reported-by tag...
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-11-13 23:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-28 8:43 [PATCH][RESEND] tracing: fix a build error on alpha Frederic Weisbecker
2008-10-28 8:53 ` Ingo Molnar
2008-11-13 22:52 ` Alexey Dobriyan
2008-11-13 23:11 ` Ingo Molnar
2008-11-13 23:28 ` Frédéric Weisbecker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.