All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@domain.hid>
To: xenomai-core <xenomai@xenomai.org>
Cc: Jan Kiszka <jan.kiszka@domain.hid>,
	Sebastian Smolorz <Sebastian.Smolorz@domain.hid>
Subject: [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration
Date: Wed, 29 Oct 2008 13:37:24 +0100	[thread overview]
Message-ID: <49085904.8080302@domain.hid> (raw)

Hi Jan and Sebastian,

attached is the patch fixing the filter problem. I'm going to apply it
to the trunk as well if there are no complaints.

Wolfgang.

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 4287)
+++ ChangeLog	(working copy)
@@ -1,3 +1,9 @@
+2008-10-29  Wolfgang Grandegger  <wg@domain.hid>
+
+	* ksrc/drivers/can/rtcan_raw_filter.c(rtcan_raw_mount_filter):
+	Applying the filter mask required for fast filter checks got lost
+	somehow with commit 2202.
+
 2008-10-28  Gilles Chanteperdrix  <gilles.chanteperdrix@xenomai.org>
 
 	* ksrc/nucleus/thread.c (xnthread_init): Change initialization
Index: ksrc/drivers/can/rtcan_raw_filter.c
===================================================================
--- ksrc/drivers/can/rtcan_raw_filter.c	(revision 4287)
+++ ksrc/drivers/can/rtcan_raw_filter.c	(working copy)
@@ -62,6 +62,9 @@
 	recv_filter->can_id = filter->can_id;
 	recv_filter->can_mask = filter->can_mask & ~CAN_INV_FILTER;
     }
+
+    /* Apply mask for fast filter check */
+    recv_filter->can_id &= recv_filter->can_mask;
 }
 
 



             reply	other threads:[~2008-10-29 12:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 12:37 Wolfgang Grandegger [this message]
2008-10-29 13:01 ` [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration Sebastian Smolorz
2008-10-30  0:26 ` Jan Kiszka
2008-10-30 11:25   ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49085904.8080302@domain.hid \
    --to=wg@domain.hid \
    --cc=Sebastian.Smolorz@domain.hid \
    --cc=jan.kiszka@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.