Re: [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

Wolfgang Grandegger wrote:
> Hi Jan and Sebastian,
> 
> attached is the patch fixing the filter problem. I'm going to apply it
> to the trunk as well if there are no complaints.
> 
> Wolfgang.
> 
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 4287)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,9 @@
> +2008-10-29  Wolfgang Grandegger  <wg@domain.hid>
> +
> +	* ksrc/drivers/can/rtcan_raw_filter.c(rtcan_raw_mount_filter):
> +	Applying the filter mask required for fast filter checks got lost
> +	somehow with commit 2202.
> +
>  2008-10-28  Gilles Chanteperdrix  <gilles.chanteperdrix@xenomai.org>
>  
>  	* ksrc/nucleus/thread.c (xnthread_init): Change initialization
> Index: ksrc/drivers/can/rtcan_raw_filter.c
> ===================================================================
> --- ksrc/drivers/can/rtcan_raw_filter.c	(revision 4287)
> +++ ksrc/drivers/can/rtcan_raw_filter.c	(working copy)
> @@ -62,6 +62,9 @@
>  	recv_filter->can_id = filter->can_id;
>  	recv_filter->can_mask = filter->can_mask & ~CAN_INV_FILTER;
>      }
> +
> +    /* Apply mask for fast filter check */
> +    recv_filter->can_id &= recv_filter->can_mask;
>  }
>  
>  

Ack from me, too. Please commit to trunk and 2.4.x.

Thanks for spotting this, Sebastian!

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]