* [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
@ 2008-10-29 4:39 ` Zhang, Xiantao
0 siblings, 0 replies; 16+ messages in thread
From: Zhang, Xiantao @ 2008-10-29 4:39 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Hi, Avi
Please review and apply the three patches! The last two are key fixes for linux-2.6.28-rc2, and please also push them into upstream.
Thanks!
Xiantao
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-29 4:39 ` Zhang, Xiantao
@ 2008-10-29 14:27 ` Avi Kivity
-1 siblings, 0 replies; 16+ messages in thread
From: Avi Kivity @ 2008-10-29 14:27 UTC (permalink / raw)
To: kvm-ia64
Zhang, Xiantao wrote:
> Hi, Avi
> Please review and apply the three patches! The last two are key fixes for linux-2.6.28-rc2, and please also push them into upstream.
>
Applied all, thanks. Is the third patch needed for 2.6.28? What
scenario does it fix?
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-29 14:27 ` Avi Kivity
@ 2008-10-29 14:33 ` Jes Sorensen
-1 siblings, 0 replies; 16+ messages in thread
From: Jes Sorensen @ 2008-10-29 14:33 UTC (permalink / raw)
To: kvm-ia64
>>>>> "Avi" = Avi Kivity <avi@redhat.com> writes:
Avi> Zhang, Xiantao wrote:
>> Hi, Avi Please review and apply the three patches! The last two
>> are key fixes for linux-2.6.28-rc2, and please also push them into
>> upstream.
Avi> Applied all, thanks. Is the third patch needed for 2.6.28? What
Avi> scenario does it fix?
Please!
The third patch reorganizes the data structures which saves us a ton
of space so we can go from 8 to 60 vcpus .... Would like it in as I
have stuff that I want to fix that goes on top of this.
Thanks,
Jes
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
@ 2008-10-29 14:33 ` Jes Sorensen
0 siblings, 0 replies; 16+ messages in thread
From: Jes Sorensen @ 2008-10-29 14:33 UTC (permalink / raw)
To: Avi Kivity; +Cc: Zhang, Xiantao, kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
>>>>> "Avi" == Avi Kivity <avi@redhat.com> writes:
Avi> Zhang, Xiantao wrote:
>> Hi, Avi Please review and apply the three patches! The last two
>> are key fixes for linux-2.6.28-rc2, and please also push them into
>> upstream.
Avi> Applied all, thanks. Is the third patch needed for 2.6.28? What
Avi> scenario does it fix?
Please!
The third patch reorganizes the data structures which saves us a ton
of space so we can go from 8 to 60 vcpus .... Would like it in as I
have stuff that I want to fix that goes on top of this.
Thanks,
Jes
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-29 14:33 ` Jes Sorensen
@ 2008-10-29 14:45 ` Avi Kivity
-1 siblings, 0 replies; 16+ messages in thread
From: Avi Kivity @ 2008-10-29 14:45 UTC (permalink / raw)
To: kvm-ia64
Jes Sorensen wrote:
> Avi> Applied all, thanks. Is the third patch needed for 2.6.28? What
> Avi> scenario does it fix?
>
> Please!
>
> The third patch reorganizes the data structures which saves us a ton
> of space so we can go from 8 to 60 vcpus .... Would like it in as I
> have stuff that I want to fix that goes on top of this.
>
>
No, that's the first patch. And it was applied, but for 2.6.29, not 2.6.28.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
@ 2008-10-29 14:45 ` Avi Kivity
0 siblings, 0 replies; 16+ messages in thread
From: Avi Kivity @ 2008-10-29 14:45 UTC (permalink / raw)
To: Jes Sorensen
Cc: Zhang, Xiantao, kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Jes Sorensen wrote:
> Avi> Applied all, thanks. Is the third patch needed for 2.6.28? What
> Avi> scenario does it fix?
>
> Please!
>
> The third patch reorganizes the data structures which saves us a ton
> of space so we can go from 8 to 60 vcpus .... Would like it in as I
> have stuff that I want to fix that goes on top of this.
>
>
No, that's the first patch. And it was applied, but for 2.6.29, not 2.6.28.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-29 14:45 ` Avi Kivity
@ 2008-10-29 14:51 ` Jes Sorensen
-1 siblings, 0 replies; 16+ messages in thread
From: Jes Sorensen @ 2008-10-29 14:51 UTC (permalink / raw)
To: kvm-ia64
Avi Kivity wrote:
> Jes Sorensen wrote:
>> The third patch reorganizes the data structures which saves us a ton
>> of space so we can go from 8 to 60 vcpus .... Would like it in as I
>> have stuff that I want to fix that goes on top of this.
>
> No, that's the first patch. And it was applied, but for 2.6.29, not
> 2.6.28.
DOH! You're right! I just looked at the 3rd patch in my inbox, without
checking the subject line :-)
I'll let Xiantao answer, I don't know the 3rd patch.
cheers
Jes
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
@ 2008-10-29 14:51 ` Jes Sorensen
0 siblings, 0 replies; 16+ messages in thread
From: Jes Sorensen @ 2008-10-29 14:51 UTC (permalink / raw)
To: Avi Kivity; +Cc: Zhang, Xiantao, kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Avi Kivity wrote:
> Jes Sorensen wrote:
>> The third patch reorganizes the data structures which saves us a ton
>> of space so we can go from 8 to 60 vcpus .... Would like it in as I
>> have stuff that I want to fix that goes on top of this.
>
> No, that's the first patch. And it was applied, but for 2.6.29, not
> 2.6.28.
DOH! You're right! I just looked at the 3rd patch in my inbox, without
checking the subject line :-)
I'll let Xiantao answer, I don't know the 3rd patch.
cheers
Jes
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-29 14:27 ` Avi Kivity
@ 2008-10-30 1:05 ` Zhang, Xiantao
-1 siblings, 0 replies; 16+ messages in thread
From: Zhang, Xiantao @ 2008-10-30 1:05 UTC (permalink / raw)
To: kvm-ia64
Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Hi, Avi
>> Please review and apply the three patches! The last two are key
>> fixes for linux-2.6.28-rc2, and please also push them into upstream.
>>
>
> Applied all, thanks. Is the third patch needed for 2.6.28? What
> scenario does it fix?
Hi, Avi
It is a potential issue. If the vcpu goes to halt with the lock taken, other vcpus wants to take write lock, they have to wait until the all halted vcpus are waken up, so it may impact performance. :)
Thanks
Xiantao
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
@ 2008-10-30 1:05 ` Zhang, Xiantao
0 siblings, 0 replies; 16+ messages in thread
From: Zhang, Xiantao @ 2008-10-30 1:05 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Hi, Avi
>> Please review and apply the three patches! The last two are key
>> fixes for linux-2.6.28-rc2, and please also push them into upstream.
>>
>
> Applied all, thanks. Is the third patch needed for 2.6.28? What
> scenario does it fix?
Hi, Avi
It is a potential issue. If the vcpu goes to halt with the lock taken, other vcpus wants to take write lock, they have to wait until the all halted vcpus are waken up, so it may impact performance. :)
Thanks
Xiantao
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-30 1:05 ` Zhang, Xiantao
@ 2008-10-30 9:36 ` Avi Kivity
-1 siblings, 0 replies; 16+ messages in thread
From: Avi Kivity @ 2008-10-30 9:36 UTC (permalink / raw)
To: kvm-ia64
Zhang, Xiantao wrote:
> It is a potential issue. If the vcpu goes to halt with the lock taken, other vcpus wants to take write lock, they have to wait until the all halted vcpus are waken up, so it may impact performance. :)
What is the impact? Taking slots_lock for write is very rare.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
2008-10-30 9:36 ` Avi Kivity
@ 2008-10-30 10:16 ` Zhang, Xiantao
-1 siblings, 0 replies; 16+ messages in thread
From: Zhang, Xiantao @ 2008-10-30 10:16 UTC (permalink / raw)
To: kvm-ia64
Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> It is a potential issue. If the vcpu goes to halt with the lock
>> taken, other vcpus wants to take write lock, they have to wait until
>> the all halted vcpus are waken up, so it may impact performance.
>> :)
>
> What is the impact? Taking slots_lock for write is very rare.
Agree, so I just say it is a potential issue in future. If not proper for 2.6.28, it should be also Okay to merge it into 2.6.29:)
Xiantao
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [00/03][PATCH] kvm-ia64 updates for linux-2.6.28-rc2
@ 2008-10-30 10:16 ` Zhang, Xiantao
0 siblings, 0 replies; 16+ messages in thread
From: Zhang, Xiantao @ 2008-10-30 10:16 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org
Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> It is a potential issue. If the vcpu goes to halt with the lock
>> taken, other vcpus wants to take write lock, they have to wait until
>> the all halted vcpus are waken up, so it may impact performance.
>> :)
>
> What is the impact? Taking slots_lock for write is very rare.
Agree, so I just say it is a potential issue in future. If not proper for 2.6.28, it should be also Okay to merge it into 2.6.29:)
Xiantao
^ permalink raw reply [flat|nested] 16+ messages in thread