From: Nathan Fontenot <nfont@austin.ibm.com>
To: gerald.schaefer@de.ibm.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
y-goto@jp.fujitsu.com, dave@linux.vnet.ibm.com
Subject: Re: [PATCH] memory hotplug: fix page_zone() calculation in test_pages_isolated()
Date: Wed, 29 Oct 2008 13:00:44 -0500 [thread overview]
Message-ID: <4908A4CC.3000300@austin.ibm.com> (raw)
In-Reply-To: <1225290330.10021.7.camel@t60p>
Looks like you beat me to it, and with a nicer fix too.
Gerald Schaefer wrote:
> From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
>
> My last bugfix here (adding zone->lock) introduced a new problem: Using
> page_zone(pfn_to_page(pfn)) to get the zone after the for() loop is wrong.
> pfn will then be >= end_pfn, which may be in a different zone or not
> present at all. This may lead to an addressing exception in page_zone()
> or spin_lock_irqsave().
>
> Now I use __first_valid_page() again after the loop to find a valid page
> for page_zone().
>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Acked-by: Nathan Fontenot <nfont@austin.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Fontenot <nfont@austin.ibm.com>
To: gerald.schaefer@de.ibm.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
y-goto@jp.fujitsu.com, dave@linux.vnet.ibm.com
Subject: Re: [PATCH] memory hotplug: fix page_zone() calculation in test_pages_isolated()
Date: Wed, 29 Oct 2008 13:00:44 -0500 [thread overview]
Message-ID: <4908A4CC.3000300@austin.ibm.com> (raw)
In-Reply-To: <1225290330.10021.7.camel@t60p>
Looks like you beat me to it, and with a nicer fix too.
Gerald Schaefer wrote:
> From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
>
> My last bugfix here (adding zone->lock) introduced a new problem: Using
> page_zone(pfn_to_page(pfn)) to get the zone after the for() loop is wrong.
> pfn will then be >= end_pfn, which may be in a different zone or not
> present at all. This may lead to an addressing exception in page_zone()
> or spin_lock_irqsave().
>
> Now I use __first_valid_page() again after the loop to find a valid page
> for page_zone().
>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Acked-by: Nathan Fontenot <nfont@austin.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-29 18:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 14:25 [PATCH] memory hotplug: fix page_zone() calculation in test_pages_isolated() Gerald Schaefer
2008-10-29 14:25 ` Gerald Schaefer, Gerald Schaefer
2008-10-29 18:00 ` Nathan Fontenot [this message]
2008-10-29 18:00 ` Nathan Fontenot
2008-10-30 0:09 ` KAMEZAWA Hiroyuki
2008-10-30 0:09 ` KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2008-10-27 16:49 Gerald Schaefer
2008-10-27 16:49 ` Gerald Schaefer, Gerald Schaefer
2008-10-27 17:17 ` Gerald Schaefer
2008-10-27 17:17 ` Gerald Schaefer
2008-10-27 17:19 ` Gerald Schaefer
2008-10-27 17:19 ` Gerald Schaefer, Gerald Schaefer
2008-10-27 17:25 ` Dave Hansen
2008-10-27 17:25 ` Dave Hansen
2008-10-27 17:59 ` Gerald Schaefer
2008-10-27 17:59 ` Gerald Schaefer
2008-10-28 0:32 ` KAMEZAWA Hiroyuki
2008-10-28 0:32 ` KAMEZAWA Hiroyuki
2008-10-28 13:00 ` Gerald Schaefer
2008-10-28 13:00 ` Gerald Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4908A4CC.3000300@austin.ibm.com \
--to=nfont@austin.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.