From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86: fix preemptable page type handling(v2)
Date: Thu, 30 Oct 2008 14:56:00 +0000 [thread overview]
Message-ID: <4909D910.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C52F7961.28970%keir.fraser@eu.citrix.com>
>>> Keir Fraser <keir.fraser@eu.citrix.com> 30.10.08 15:46 >>>
>Why does this patch not do what the new comment says and directly get_page()
>when PGT_partial is set and put_page() when PGT_partial is cleared? Doing
Hmm, the description was meant to tell the net effect, not the way it's
implemented.
>get_page() across all __put_page() operations and then skipping the
>put_page() in some cases, for example, seems inefficient and also makes the
>code less clear. Why would you do it that way?
Because I can't handle a failure of get_page() (due to count overflow)
once I'm past the put()s.
Jan
next prev parent reply other threads:[~2008-10-30 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 12:27 [PATCH] x86: fix preemptable page type handling (v2) Jan Beulich
2008-10-30 14:46 ` Keir Fraser
2008-10-30 14:56 ` Jan Beulich [this message]
2008-10-30 15:00 ` [PATCH] x86: fix preemptable page type handling(v2) Keir Fraser
2008-10-30 17:03 ` [PATCH] x86: fix preemptable page typehandling(v2) Jan Beulich
2008-10-30 17:27 ` Keir Fraser
2008-10-30 21:19 ` Use of the "has_shutdown_code" code in v3.2 Roger Cruz
2008-10-30 22:02 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4909D910.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.