From: Mike Ditto <mditto-Vjf7OWgA3BLqlBn2x/YWAg@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: Jochen Friedrich <jochen-NIgtFMG+Po8@public.gmane.org>,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c-cpm: Detect and report NAK right away instead of timing out.
Date: Sun, 02 Nov 2008 19:50:20 -0800 [thread overview]
Message-ID: <490E74FC.4060106@consentry.com> (raw)
In-Reply-To: <20081103002328.GC30438-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
Ben Dooks wrote:
>> When reading from a device that is not present or declines to respond
>> to, e.g., a non-existent register address, CPM immediately reports a
>> NAK condition in the TxBD, but the driver kept waiting until a timeout,
>> which takes 1 second and causes an ugly console error message.
>
> hmm, that block of text could probably go into the patch description.
It's certainly fine with me if you want to include it. I was just
trying, perhaps inappropriately, to separate the "bug report" from the
"description of the change".
-=] Mike [=-
WARNING: multiple messages have this Message-ID (diff)
From: Mike Ditto <mditto@consentry.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-cpm: Detect and report NAK right away instead of timing out.
Date: Sun, 02 Nov 2008 19:50:20 -0800 [thread overview]
Message-ID: <490E74FC.4060106@consentry.com> (raw)
In-Reply-To: <20081103002328.GC30438@fluff.org.uk>
Ben Dooks wrote:
>> When reading from a device that is not present or declines to respond
>> to, e.g., a non-existent register address, CPM immediately reports a
>> NAK condition in the TxBD, but the driver kept waiting until a timeout,
>> which takes 1 second and causes an ugly console error message.
>
> hmm, that block of text could probably go into the patch description.
It's certainly fine with me if you want to include it. I was just
trying, perhaps inappropriately, to separate the "bug report" from the
"description of the change".
-=] Mike [=-
next prev parent reply other threads:[~2008-11-03 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 0:29 [PATCH] i2c-cpm: Detect and report NAK right away instead of timing out Mike Ditto
2008-11-01 0:29 ` Mike Ditto
[not found] ` <490BA2E5.8010309-Vjf7OWgA3BLqlBn2x/YWAg@public.gmane.org>
2008-11-03 0:23 ` Ben Dooks
2008-11-03 0:23 ` Ben Dooks
[not found] ` <20081103002328.GC30438-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-11-03 3:50 ` Mike Ditto [this message]
2008-11-03 3:50 ` Mike Ditto
2008-11-03 11:44 ` Jochen Friedrich
2008-11-03 11:44 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490E74FC.4060106@consentry.com \
--to=mditto-vjf7owga3blqlbn2x/ywag@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=jochen-NIgtFMG+Po8@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.