All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sched debug: remove sd_level_to_string()
@ 2008-11-04  8:15 Li Zefan
  2008-11-04  9:20 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Li Zefan @ 2008-11-04  8:15 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: LKML, Peter Zijlstra

Just use sd->name.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/sched.c |   25 +------------------------
 1 files changed, 1 insertions(+), 24 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index bf75a5e..baa7e4b 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -6622,28 +6622,6 @@ early_initcall(migration_init);
 
 #ifdef CONFIG_SCHED_DEBUG
 
-static inline const char *sd_level_to_string(enum sched_domain_level lvl)
-{
-	switch (lvl) {
-	case SD_LV_NONE:
-			return "NONE";
-	case SD_LV_SIBLING:
-			return "SIBLING";
-	case SD_LV_MC:
-			return "MC";
-	case SD_LV_CPU:
-			return "CPU";
-	case SD_LV_NODE:
-			return "NODE";
-	case SD_LV_ALLNODES:
-			return "ALLNODES";
-	case SD_LV_MAX:
-			return "MAX";
-
-	}
-	return "MAX";
-}
-
 static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
 				  cpumask_t *groupmask)
 {
@@ -6663,8 +6641,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
 		return -1;
 	}
 
-	printk(KERN_CONT "span %s level %s\n",
-		str, sd_level_to_string(sd->level));
+	printk(KERN_CONT "span %s level %s\n", str, sd->name);
 
 	if (!cpu_isset(cpu, sd->span)) {
 		printk(KERN_ERR "ERROR: domain->span does not contain "
-- 
1.5.4.rc3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sched debug: remove sd_level_to_string()
  2008-11-04  8:15 [PATCH] sched debug: remove sd_level_to_string() Li Zefan
@ 2008-11-04  9:20 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-04  9:20 UTC (permalink / raw)
  To: Li Zefan; +Cc: LKML, Peter Zijlstra


* Li Zefan <lizf@cn.fujitsu.com> wrote:

> Just use sd->name.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
>  kernel/sched.c |   25 +------------------------
>  1 files changed, 1 insertions(+), 24 deletions(-)

heh, nice. Applied to tip/sched/core, thanks!

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-04  9:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-04  8:15 [PATCH] sched debug: remove sd_level_to_string() Li Zefan
2008-11-04  9:20 ` Ingo Molnar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.