* [PATCH] kvm-userspace: add ibm archs to unifdef header
@ 2008-11-03 17:15 ` Ehrhardt Christian
0 siblings, 0 replies; 8+ messages in thread
From: Ehrhardt Christian @ 2008-11-03 17:15 UTC (permalink / raw)
To: kvm-ppc, kvm, avi; +Cc: ehrhardt, hollisb, borntraeger, cotte
This adds powerpc to the unifdef header avi introduced.
I think s390 should work the same way and is needed as they have libkvm already.
Christian/Carsten could you ack that after a quick test if it is working?
Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
---
[diffstat]
unifdef.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
[diff]
diff --git a/kernel/unifdef.h b/kernel/unifdef.h
--- a/kernel/unifdef.h
+++ b/kernel/unifdef.h
@@ -25,4 +25,16 @@
#endif
#endif
+#ifdef __PPC__
+#ifndef CONFIG_PPC
+#define CONFIG_PPC 1
#endif
+#endif
+
+#ifdef __s390__
+#ifndef CONFIG_S390
+#define CONFIG_S390 1
+#endif
+#endif
+
+#endif
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] kvm-userspace: add ibm archs to unifdef header
@ 2008-11-03 17:15 ` Ehrhardt Christian
0 siblings, 0 replies; 8+ messages in thread
From: Ehrhardt Christian @ 2008-11-03 17:15 UTC (permalink / raw)
To: kvm-ppc, kvm, avi; +Cc: ehrhardt, hollisb, borntraeger, cotte
This adds powerpc to the unifdef header avi introduced.
I think s390 should work the same way and is needed as they have libkvm already.
Christian/Carsten could you ack that after a quick test if it is working?
Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
---
[diffstat]
unifdef.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
[diff]
diff --git a/kernel/unifdef.h b/kernel/unifdef.h
--- a/kernel/unifdef.h
+++ b/kernel/unifdef.h
@@ -25,4 +25,16 @@
#endif
#endif
+#ifdef __PPC__
+#ifndef CONFIG_PPC
+#define CONFIG_PPC 1
#endif
+#endif
+
+#ifdef __s390__
+#ifndef CONFIG_S390
+#define CONFIG_S390 1
+#endif
+#endif
+
+#endif
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
2008-11-03 17:15 ` Ehrhardt Christian
@ 2008-11-04 10:13 ` Avi Kivity
-1 siblings, 0 replies; 8+ messages in thread
From: Avi Kivity @ 2008-11-04 10:13 UTC (permalink / raw)
To: Ehrhardt Christian
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA, kvm-u79uwXL29TY76Z2rM5mHXA,
hollisb-r/Jw6+rmf7HQT0dZR+AlfA,
borntraeger-tA70FqPdS9bQT0dZR+AlfA, cotte-tA70FqPdS9bQT0dZR+AlfA
Ehrhardt Christian wrote:
> This adds powerpc to the unifdef header avi introduced.
> I think s390 should work the same way and is needed as they have libkvm already.
> Christian/Carsten could you ack that after a quick test if it is working?
>
>
I don't think it's really needed since we don't depend on these symbols
in arch-independent headers.
It can't hurt, though, so I don't mind applying it after s390 acks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
@ 2008-11-04 10:13 ` Avi Kivity
0 siblings, 0 replies; 8+ messages in thread
From: Avi Kivity @ 2008-11-04 10:13 UTC (permalink / raw)
To: Ehrhardt Christian
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA, kvm-u79uwXL29TY76Z2rM5mHXA,
hollisb-r/Jw6+rmf7HQT0dZR+AlfA,
borntraeger-tA70FqPdS9bQT0dZR+AlfA, cotte-tA70FqPdS9bQT0dZR+AlfA
Ehrhardt Christian wrote:
> This adds powerpc to the unifdef header avi introduced.
> I think s390 should work the same way and is needed as they have libkvm already.
> Christian/Carsten could you ack that after a quick test if it is working?
>
>
I don't think it's really needed since we don't depend on these symbols
in arch-independent headers.
It can't hurt, though, so I don't mind applying it after s390 acks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
2008-11-03 17:15 ` Ehrhardt Christian
@ 2008-11-04 11:53 ` Christian Borntraeger
-1 siblings, 0 replies; 8+ messages in thread
From: Christian Borntraeger @ 2008-11-04 11:53 UTC (permalink / raw)
To: Ehrhardt Christian; +Cc: kvm-ppc, kvm, avi, hollisb, cotte
Am Montag, 3. November 2008 schrieb Ehrhardt Christian:
> +#ifdef __s390__
> +#ifndef CONFIG_S390
> +#define CONFIG_S390 1
> +#endif
> +#endif
> +
> +#endif
>
It seems that currently no header needs this, but better save than sorry.
__s390__ is defined by gcc for s390 and s390x, CONFIG_S390 is set on s390 and
s390x in the kernel config. This looks right.
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
@ 2008-11-04 11:53 ` Christian Borntraeger
0 siblings, 0 replies; 8+ messages in thread
From: Christian Borntraeger @ 2008-11-04 11:53 UTC (permalink / raw)
To: Ehrhardt Christian; +Cc: kvm-ppc, kvm, avi, hollisb, cotte
Am Montag, 3. November 2008 schrieb Ehrhardt Christian:
> +#ifdef __s390__
> +#ifndef CONFIG_S390
> +#define CONFIG_S390 1
> +#endif
> +#endif
> +
> +#endif
>
It seems that currently no header needs this, but better save than sorry.
__s390__ is defined by gcc for s390 and s390x, CONFIG_S390 is set on s390 and
s390x in the kernel config. This looks right.
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <200811041253.04465.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
[not found] ` <200811041253.04465.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
@ 2008-11-04 13:10 ` Avi Kivity
0 siblings, 0 replies; 8+ messages in thread
From: Avi Kivity @ 2008-11-04 13:10 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Ehrhardt Christian, kvm-ppc-u79uwXL29TY76Z2rM5mHXA,
kvm-u79uwXL29TY76Z2rM5mHXA, hollisb-r/Jw6+rmf7HQT0dZR+AlfA,
cotte-tA70FqPdS9bQT0dZR+AlfA
Christian Borntraeger wrote:
> Am Montag, 3. November 2008 schrieb Ehrhardt Christian:
>
>> +#ifdef __s390__
>> +#ifndef CONFIG_S390
>> +#define CONFIG_S390 1
>> +#endif
>> +#endif
>> +
>> +#endif
>>
>>
>
> It seems that currently no header needs this, but better save than sorry.
>
> __s390__ is defined by gcc for s390 and s390x, CONFIG_S390 is set on s390 and
> s390x in the kernel config. This looks right.
>
Okay, applied. Thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
@ 2008-11-04 13:10 ` Avi Kivity
0 siblings, 0 replies; 8+ messages in thread
From: Avi Kivity @ 2008-11-04 13:10 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Ehrhardt Christian, kvm-ppc-u79uwXL29TY76Z2rM5mHXA,
kvm-u79uwXL29TY76Z2rM5mHXA, hollisb-r/Jw6+rmf7HQT0dZR+AlfA,
cotte-tA70FqPdS9bQT0dZR+AlfA
Christian Borntraeger wrote:
> Am Montag, 3. November 2008 schrieb Ehrhardt Christian:
>
>> +#ifdef __s390__
>> +#ifndef CONFIG_S390
>> +#define CONFIG_S390 1
>> +#endif
>> +#endif
>> +
>> +#endif
>>
>>
>
> It seems that currently no header needs this, but better save than sorry.
>
> __s390__ is defined by gcc for s390 and s390x, CONFIG_S390 is set on s390 and
> s390x in the kernel config. This looks right.
>
Okay, applied. Thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-11-04 13:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-03 17:15 [PATCH] kvm-userspace: add ibm archs to unifdef header Ehrhardt Christian
2008-11-03 17:15 ` Ehrhardt Christian
2008-11-04 10:13 ` Avi Kivity
2008-11-04 10:13 ` Avi Kivity
2008-11-04 11:53 ` Christian Borntraeger
2008-11-04 11:53 ` Christian Borntraeger
[not found] ` <200811041253.04465.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2008-11-04 13:10 ` Avi Kivity
2008-11-04 13:10 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.