From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] remove vcpu_info array v5
Date: Tue, 04 Nov 2008 14:47:24 +0000 [thread overview]
Message-ID: <4910607C.7040405@redhat.com> (raw)
In-Reply-To: <4909C00F.8050704@sgi.com>
Glauber Costa wrote:
>>> Yes, but I believe the whole point of jes patches is to remove those
>>> limits.
>>>
>>>
>> So we could linear search huge lists? Or code hashes where arrays would do?
>> No, sir.
>>
>> An array of pointers statically sized at MAX_CPUS is fine. If you insist,
>> you can realloc() it on demand.
>>
>
> Yes, I agree. having MAX_CPUS is fine, and if we need to, we can increase that.
> but again: then the direction of the flow is better be have qemu to
> use a env array,
> and then we can use the same method for kvm.
>
I only object to the linear search; not to the folding of vcpu_info into
CPUState.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@gmail.com>
Cc: Jes Sorensen <jes@sgi.com>, Anthony Liguori <aliguori@us.ibm.com>,
Hollis Blanchard <hollisb@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: Re: [patch] remove vcpu_info array v5
Date: Tue, 04 Nov 2008 16:47:24 +0200 [thread overview]
Message-ID: <4910607C.7040405@redhat.com> (raw)
In-Reply-To: <5d6222a80811040643y1b5233fdm89029f5acc0cbc1c@mail.gmail.com>
Glauber Costa wrote:
>>> Yes, but I believe the whole point of jes patches is to remove those
>>> limits.
>>>
>>>
>> So we could linear search huge lists? Or code hashes where arrays would do?
>> No, sir.
>>
>> An array of pointers statically sized at MAX_CPUS is fine. If you insist,
>> you can realloc() it on demand.
>>
>
> Yes, I agree. having MAX_CPUS is fine, and if we need to, we can increase that.
> but again: then the direction of the flow is better be have qemu to
> use a env array,
> and then we can use the same method for kvm.
>
I only object to the linear search; not to the folding of vcpu_info into
CPUState.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-04 14:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 14:09 [patch] remove vcpu_info array v5 Jes Sorensen
2008-10-30 14:09 ` Jes Sorensen
2008-11-04 11:54 ` Avi Kivity
2008-11-04 11:54 ` Avi Kivity
2008-11-04 13:55 ` Glauber Costa
2008-11-04 13:55 ` Glauber Costa
2008-11-04 14:30 ` Avi Kivity
2008-11-04 14:30 ` Avi Kivity
2008-11-04 14:35 ` Glauber Costa
2008-11-04 14:35 ` Glauber Costa
2008-11-04 14:40 ` Avi Kivity
2008-11-04 14:40 ` Avi Kivity
2008-11-04 14:43 ` Glauber Costa
2008-11-04 14:43 ` Glauber Costa
2008-11-04 14:47 ` Avi Kivity [this message]
2008-11-04 14:47 ` Avi Kivity
2008-11-10 12:30 ` Jes Sorensen
2008-11-10 12:30 ` Jes Sorensen
2008-11-10 13:24 ` Jes Sorensen
2008-11-10 13:24 ` Jes Sorensen
2008-11-10 13:30 ` Jes Sorensen
2008-11-10 13:30 ` Jes Sorensen
2008-11-10 13:40 ` Avi Kivity
2008-11-10 13:40 ` Avi Kivity
2008-11-10 13:48 ` Avi Kivity
2008-11-10 13:48 ` Avi Kivity
2008-11-10 15:22 ` Anthony Liguori
2008-11-10 15:22 ` Anthony Liguori
2008-11-10 15:45 ` Avi Kivity
2008-11-10 15:45 ` Avi Kivity
2008-11-10 15:47 ` Jes Sorensen
2008-11-10 15:47 ` Jes Sorensen
2008-11-10 15:54 ` Avi Kivity
2008-11-10 15:54 ` Avi Kivity
2008-11-10 15:58 ` Jes Sorensen
2008-11-10 15:58 ` Jes Sorensen
2008-11-11 9:26 ` Avi Kivity
2008-11-11 9:26 ` Avi Kivity
2008-11-12 13:02 ` Jes Sorensen
2008-11-12 13:02 ` Jes Sorensen
2008-11-12 13:09 ` Glauber Costa
2008-11-12 13:09 ` Glauber Costa
2008-11-12 13:12 ` Avi Kivity
2008-11-12 13:12 ` Avi Kivity
2008-11-12 13:14 ` Avi Kivity
2008-11-12 13:14 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-11-13 16:46 [patch] pass opague CPUState through libkvm instead of int vcpu Jes Sorensen
2008-11-13 16:46 ` Jes Sorensen
2008-11-18 12:55 ` Avi Kivity
2008-11-18 12:55 ` Avi Kivity
2008-11-18 12:59 ` Jes Sorensen
2008-11-18 12:59 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4910607C.7040405@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.