All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select
Date: Tue, 04 Nov 2008 11:38:38 -0600	[thread overview]
Message-ID: <4910889E.1050200@codemonkey.ws> (raw)
In-Reply-To: <49108333.6080807@web.de>

Jan Kiszka wrote:
> Anthony Liguori wrote:
>   
>> Anthony Liguori wrote:
>>     
>>> Jan Kiszka wrote:
>>>
>>> Perhaps we should move the alarm timer check rearming out of the main
>>> loop and into a qemu_set_fd_handler2() handler?
>>>       
>> And now that I think about it, I see no reason why the timer expiration
>> checks couldn't be moved to the same handler.  I'd have to look more
>> closely at how that would interact with icount though.
>>     
>
> I cannot yet follow you here. But I my impression is that this will be
> an additional change that should come in a separate patch, no?
>   

Yeah, I can take care of that.  This is general cleanup that I've wanted 
to do to the main loop.

> Find the O_NONBLOCK remark addressed below.
>   

Great!  I'll give it a spin.

Regards,

Anthony Liguori

  reply	other threads:[~2008-11-04 17:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  7:52 [Qemu-devel] [PATCH] Fix alarm_timer race with select Jan Kiszka
2008-11-04 14:07 ` Anthony Liguori
2008-11-04 14:27   ` Anthony Liguori
2008-11-04 17:15     ` [Qemu-devel] " Jan Kiszka
2008-11-04 17:38       ` Anthony Liguori [this message]
2008-11-04 19:16       ` Anthony Liguori
2008-11-04 19:37         ` Jan Kiszka
2008-11-05 12:36       ` Jamie Lokier
2008-11-05 13:01         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4910889E.1050200@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.