Re: [Qemu-devel] Re: [PATCH] Fix alarm_timer race with select

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Jamie Lokier wrote:
> Jan Kiszka wrote:
>> +    if (pipe(fds) || fcntl(fds[0], F_SETFL, O_NONBLOCK)
>> +        || fcntl(fds[1], F_SETFL, O_NONBLOCK)) {
> 
> Is this a portable way to set O_NONBLOCK on all host platforms?
> I'm under the impression you need to ues F_GETFL first, in case
> other flags are important to the functioning of the file descriptor.

[ Checking the spec ] That's likely true, read-modify-write is
recommended. Can changes this. Consequently, quite a few other spots in
qemu should then be changed as well...

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]