All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch V2] U-Boot Firetux board support
Date: Wed, 05 Nov 2008 15:24:20 -0800	[thread overview]
Message-ID: <49122B24.9050206@gmail.com> (raw)
In-Reply-To: <20081105124811.50f8ad76@mangold.emlix.com>

Hi Juergen,

Juergen Schoew wrote:
> Hi U-Boot mailling list,
>
> This patchset adds a new ARM board with the NXP PNX8181 cpu to u-boot.
> The PNX8181 is an ARM926ej with an internal DSP (mostly used for Audio
> processing and VOIP codecs) and a baseband processor (used for DECT). The
> chip also features dual ethernet, digital to analog interface, spi, i2c and
> other SOC peripherals.
>
> These boards have been build by NXP Semiconductors GmbH, Nuremberg, Germany
> and are now build by DSPG Technologies GmbH, Nuremberg, Germany.
>
>
> Signed-off-by: J?rgen Sch?w <js@emlix.com>
> Signed-off-by: Sebastian Hess <sh@emlix.com>
> Signed-off-by: Matthias Mwenzel <nxp@mazzoo.de>
> Signed-off-by: Dirk H?rner <dirk.hoerner@dspg.com>
> Signed-off-by: Andreas Wei?el <andreas.weissel@dspg.com>
> ---
>
> Here is the next round of the patch. Thanks for the comments so far. I tried
> to change the code to meet your requirements. Following changes have been
> done:
>
>  - use writex/readx for register accesses
>  - use pointer in readx/writex
>  - whitespace fixes (use tabs)
>  - add Maintainer field
>  - adjust comments to common style
>  - use conditional settings
>  - relocate.S bug fixes
>  - network reworks
>
> I did not move the ethernet driver to drivers/net/ because a lot of hardware
> dependencies are in that driver to work. This IP-Core is not used very often
> by NXP processors (I don't have numbers) so it may not need to be moved. This
> driver does not not use the a struct to save the parameters as suggested
> from Jean-Christophe PLAGNIOL-VILLARD. Sorry but time was too short to fix it
> right now.
>
>   
Here are the expectations for new network drivers:
1. Driver will be in driver/net.  You're not the first with hardware 
dependencies, and there are standard ways of dealing with them.
2. You must use the CONFIG_NET_MULTI-style API, where the driver is 
registered and access functions such as send, halt, recv etc. are called 
through a struct.
3. Driver is initialized through cpu_eth_init() or board_eth_init()

Without meeting these, your code will not be accepted.

regards,
Ben

  reply	other threads:[~2008-11-05 23:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 11:48 [U-Boot] [patch V2] U-Boot Firetux board support Juergen Schoew
2008-11-05 23:24 ` Ben Warren [this message]
2008-11-06 20:53 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-13 15:55   ` Jürgen Schöw
2008-11-13 16:51     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49122B24.9050206@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.