All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT
Date: Thu, 06 Nov 2008 20:02:10 +0000	[thread overview]
Message-ID: <49134D42.6080109@codemonkey.ws> (raw)
In-Reply-To: <1225968855.7284.15.camel@blaa>

Hollis Blanchard wrote:
> I wanted to make sure people on non-x86 architectures couldn't run into
> vring-size related problems that didn't also appear on x86.
>   

Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 
<< VRING_SHIFT) is almost certainly going to break things in unexpected 
ways because it's going against common understanding of the relationship 
between shift and page_size.

Regards,

Anthony Liguori



WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: rusty@rustcorp.com.au, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT
Date: Thu, 06 Nov 2008 20:02:10 +0000	[thread overview]
Message-ID: <49134D42.6080109@codemonkey.ws> (raw)
In-Reply-To: <1225998124.8620.45.camel@localhost.localdomain>

Hollis Blanchard wrote:
> I wanted to make sure people on non-x86 architectures couldn't run into
> vring-size related problems that didn't also appear on x86.
>   

Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 
<< VRING_SHIFT) is almost certainly going to break things in unexpected 
ways because it's going against common understanding of the relationship 
between shift and page_size.

Regards,

Anthony Liguori



WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: rusty@rustcorp.com.au, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] qemu: define and use VIRTIO_PFN_SHIFT
Date: Thu, 06 Nov 2008 14:02:10 -0600	[thread overview]
Message-ID: <49134D42.6080109@codemonkey.ws> (raw)
In-Reply-To: <1225998124.8620.45.camel@localhost.localdomain>

Hollis Blanchard wrote:
> I wanted to make sure people on non-x86 architectures couldn't run into
> vring-size related problems that didn't also appear on x86.
>   

Having a VRING_SHIFT and a VRING_PAGE_SIZE where VRING_PAGE_SIZE != (1 
<< VRING_SHIFT) is almost certainly going to break things in unexpected 
ways because it's going against common understanding of the relationship 
between shift and page_size.

Regards,

Anthony Liguori



  parent reply	other threads:[~2008-11-06 20:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 10:54 [PATCH] qemu: define and use VIRTIO_PFN_SHIFT Mark McLoughlin
2008-11-06 10:54 ` Mark McLoughlin
2008-11-06 10:54 ` Mark McLoughlin
2008-11-06 14:01 ` Anthony Liguori
2008-11-06 14:01   ` Anthony Liguori
2008-11-06 14:01   ` Anthony Liguori
2008-11-06 19:02 ` Hollis Blanchard
2008-11-06 19:02   ` Hollis Blanchard
2008-11-06 19:02   ` Hollis Blanchard
2008-11-06 20:02 ` Anthony Liguori [this message]
2008-11-06 20:02   ` Anthony Liguori
2008-11-06 20:02   ` Anthony Liguori
2008-11-07  1:38 ` Zhang, Xiantao
2008-11-07  1:38   ` Zhang, Xiantao
2008-11-07  1:38   ` Zhang, Xiantao
2008-11-07  5:05 ` Hollis Blanchard
2008-11-07  5:05   ` Hollis Blanchard
2008-11-07  5:05   ` Hollis Blanchard
2008-11-10  5:55 ` Zhang, Xiantao
2008-11-10  5:55   ` Zhang, Xiantao
2008-11-10  5:55   ` Zhang, Xiantao
  -- strict thread matches above, loose matches on Subject: below --
2008-11-06 23:27 dynamic virtio page size Hollis Blanchard
2008-11-06 23:27 ` Hollis Blanchard
2008-11-06 23:27 ` Hollis Blanchard
2008-11-06 23:32 ` Hollis Blanchard
2008-11-06 23:32   ` Hollis Blanchard
2008-11-06 23:32   ` Hollis Blanchard
2008-11-06  4:49 [PATCH] qemu: define and use VIRTIO_PFN_SHIFT Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49134D42.6080109@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.