From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"Christopher S. Aker" <caker@theshore.net>,
xen devel <xen-devel@lists.xensource.com>,
Jan Beulich <jbeulich@novell.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU
Date: Thu, 06 Nov 2008 13:20:04 -0800 [thread overview]
Message-ID: <49135F84.2060302@goop.org> (raw)
In-Reply-To: <20081106211639.GA24579@elte.hu>
Ingo Molnar wrote:
> a "cleanup" impact line is only added if the change is not intended to
> have any side-effects whatsoever.
>
> We can drop it but it would be really nice to figure out what's going
> on. In a very quick late-night look i cannot see anything particularly
> weird about it, but based on the type of changes it does there are
> three leading candidates: lost high 32 bits, zero extend problem, or
> incorrect types.
Yeah, I couldn't see anything either. It's a reasonable cleanup (I
never did understand that struct page * cast), but its always nicer when
cleanups don't break working code ;).
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xen devel <xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: 2.6.27 - SMP enabled, but only 1 CPU
Date: Thu, 06 Nov 2008 13:20:04 -0800 [thread overview]
Message-ID: <49135F84.2060302@goop.org> (raw)
In-Reply-To: <20081106211639.GA24579@elte.hu>
Ingo Molnar wrote:
> a "cleanup" impact line is only added if the change is not intended to
> have any side-effects whatsoever.
>
> We can drop it but it would be really nice to figure out what's going
> on. In a very quick late-night look i cannot see anything particularly
> weird about it, but based on the type of changes it does there are
> three leading candidates: lost high 32 bits, zero extend problem, or
> incorrect types.
Yeah, I couldn't see anything either. It's a reasonable cleanup (I
never did understand that struct page * cast), but its always nicer when
cleanups don't break working code ;).
J
next prev parent reply other threads:[~2008-11-06 21:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 21:24 2.6.27 - SMP enabled, but only 1 CPU Christopher S. Aker
[not found] ` <490F5F50.7020704@theshore.net>
2008-11-04 20:13 ` Christopher S. Aker
2008-11-05 15:31 ` Christopher S. Aker
2008-11-05 22:38 ` Jeremy Fitzhardinge
2008-11-05 22:57 ` Christopher S. Aker
2008-11-05 22:45 ` Jeremy Fitzhardinge
2008-11-05 23:05 ` Christopher S. Aker
2008-11-06 0:23 ` Jeremy Fitzhardinge
2008-11-06 2:00 ` Christopher S. Aker
2008-11-06 2:23 ` Stefan de Konink
2008-11-06 3:43 ` Jeremy Fitzhardinge
2008-11-06 18:04 ` Ian Campbell
2008-11-06 19:15 ` [Xen-devel] " Jeremy Fitzhardinge
2008-11-06 19:15 ` Jeremy Fitzhardinge
2008-11-06 21:16 ` [Xen-devel] " Ingo Molnar
2008-11-06 21:16 ` Ingo Molnar
2008-11-06 21:20 ` Jeremy Fitzhardinge [this message]
2008-11-06 21:20 ` Jeremy Fitzhardinge
2008-11-06 21:22 ` [Xen-devel] " Ingo Molnar
2008-11-06 21:22 ` Ingo Molnar
2008-11-06 21:28 ` [Xen-devel] " Jeremy Fitzhardinge
2008-11-06 21:28 ` Jeremy Fitzhardinge
2008-11-06 21:33 ` [Xen-devel] " Ingo Molnar
2008-11-06 21:33 ` Ingo Molnar
2008-11-06 21:48 ` [Xen-devel] " Jeremy Fitzhardinge
2008-11-06 21:48 ` Jeremy Fitzhardinge
2008-11-06 22:20 ` [Xen-devel] " Ingo Molnar
2008-11-06 22:20 ` Ingo Molnar
2008-11-06 22:29 ` [Xen-devel] " Jeremy Fitzhardinge
2008-11-06 22:29 ` Jeremy Fitzhardinge
2008-11-07 9:53 ` [Xen-devel] " Jan Beulich
2008-11-07 9:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49135F84.2060302@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@citrix.com \
--cc=caker@theshore.net \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.