All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilko Iliev <iliev@ronetix.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] broken lib_arm/boom.c/do_bootm_linux()
Date: Fri, 07 Nov 2008 12:07:26 +0100	[thread overview]
Message-ID: <4914216E.4010902@ronetix.at> (raw)

Hi,

There is a bug in lib_arm/boom.c/do_bootm_linux():
    if ((flag != 0) || (flag != BOOTM_STATE_OS_GO))
        return 1;

The parameter "flag" is 0 and the above condition is always true.

The result is - the boom command doesn't start the kernel.
Affected targets: all arm based.

Maybe it should be corrected to:
    if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
        return 1;


-- 
With best regards,
Ilko Iliev
Ronetix Development Tools GmbH
CPU Modules, JTAG/BDM Emulators and Flash Programmers
Waidhausenstrasse 13/5, 1140 Vienna, Austria
E-Mail: iliev at ronetix.at; Web: www.ronetix.at

             reply	other threads:[~2008-11-07 11:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 11:07 Ilko Iliev [this message]
2008-11-07 14:01 ` [U-Boot] broken lib_arm/boom.c/do_bootm_linux() Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4914216E.4010902@ronetix.at \
    --to=iliev@ronetix.at \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.