* [U-Boot] broken lib_arm/boom.c/do_bootm_linux()
@ 2008-11-07 11:07 Ilko Iliev
2008-11-07 14:01 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Ilko Iliev @ 2008-11-07 11:07 UTC (permalink / raw)
To: u-boot
Hi,
There is a bug in lib_arm/boom.c/do_bootm_linux():
if ((flag != 0) || (flag != BOOTM_STATE_OS_GO))
return 1;
The parameter "flag" is 0 and the above condition is always true.
The result is - the boom command doesn't start the kernel.
Affected targets: all arm based.
Maybe it should be corrected to:
if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
return 1;
--
With best regards,
Ilko Iliev
Ronetix Development Tools GmbH
CPU Modules, JTAG/BDM Emulators and Flash Programmers
Waidhausenstrasse 13/5, 1140 Vienna, Austria
E-Mail: iliev at ronetix.at; Web: www.ronetix.at
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] broken lib_arm/boom.c/do_bootm_linux()
2008-11-07 11:07 [U-Boot] broken lib_arm/boom.c/do_bootm_linux() Ilko Iliev
@ 2008-11-07 14:01 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2008-11-07 14:01 UTC (permalink / raw)
To: u-boot
On Nov 7, 2008, at 5:07 AM, Ilko Iliev wrote:
> Hi,
>
> There is a bug in lib_arm/boom.c/do_bootm_linux():
> if ((flag != 0) || (flag != BOOTM_STATE_OS_GO))
> return 1;
>
> The parameter "flag" is 0 and the above condition is always true.
>
> The result is - the boom command doesn't start the kernel.
> Affected targets: all arm based.
>
> Maybe it should be corrected to:
> if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
> return 1;
>
that's correct.. for some reason the lib_arm/ case didn't get fixed.
How about sending a patch to fix it.
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-07 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-07 11:07 [U-Boot] broken lib_arm/boom.c/do_bootm_linux() Ilko Iliev
2008-11-07 14:01 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.