All of lore.kernel.org
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@in.ibm.com>, linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.28-rc3 mem_cgroup panic
Date: Fri, 07 Nov 2008 21:00:47 -0800	[thread overview]
Message-ID: <49151CFF.8060503@us.ibm.com> (raw)
In-Reply-To: <38971.10.75.179.62.1226112376.squirrel@webmail-b.css.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> KAMEZAWA Hiroyuki said:
>   
>> Badari Pulavarty said:
>>     
>>> Hi Balbir,
>>>
>>> I was running memory remove/add tests in a continuous loop.
>>> I get following panic in mem_cgroup migration code.
>>>
>>> Is this a known issue ?
>>>
>>>       
>> No, this is new one. We don't see panic in cpuset based migration..so..
>> Maybe related to page_cgroup allocation/free code in memory hotplug
>> notifier.
>>
>> Thank you for report. I'll try this.
>>
>>     
> Hmm...at quick look...
>
> online/offline page_cgroup's calculation for "start" is buggy..
>
> -start = start_pfn & (PAGES_PER_SECTION - 1);
> +start = start_pfn & ~(PAGES_PER_SECTION - 1);
>
> I'm sorry I can't write patch today.
>
> Regards,
> -Kame
>
>   

Thanks for the fix. Tests are running fine now.

Thanks,
Badari



WARNING: multiple messages have this Message-ID (diff)
From: Badari Pulavarty <pbadari@us.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@in.ibm.com>, linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.28-rc3 mem_cgroup panic
Date: Fri, 07 Nov 2008 21:00:47 -0800	[thread overview]
Message-ID: <49151CFF.8060503@us.ibm.com> (raw)
In-Reply-To: <38971.10.75.179.62.1226112376.squirrel@webmail-b.css.fujitsu.com>

KAMEZAWA Hiroyuki wrote:
> KAMEZAWA Hiroyuki said:
>   
>> Badari Pulavarty said:
>>     
>>> Hi Balbir,
>>>
>>> I was running memory remove/add tests in a continuous loop.
>>> I get following panic in mem_cgroup migration code.
>>>
>>> Is this a known issue ?
>>>
>>>       
>> No, this is new one. We don't see panic in cpuset based migration..so..
>> Maybe related to page_cgroup allocation/free code in memory hotplug
>> notifier.
>>
>> Thank you for report. I'll try this.
>>
>>     
> Hmm...at quick look...
>
> online/offline page_cgroup's calculation for "start" is buggy..
>
> -start = start_pfn & (PAGES_PER_SECTION - 1);
> +start = start_pfn & ~(PAGES_PER_SECTION - 1);
>
> I'm sorry I can't write patch today.
>
> Regards,
> -Kame
>
>   

Thanks for the fix. Tests are running fine now.

Thanks,
Badari


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-11-08  5:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 22:29 2.6.28-rc3 mem_cgroup panic Badari Pulavarty
2008-11-07 22:29 ` Badari Pulavarty
2008-11-08  2:24 ` KAMEZAWA Hiroyuki
2008-11-08  2:24   ` KAMEZAWA Hiroyuki
2008-11-08  2:46   ` KAMEZAWA Hiroyuki
2008-11-08  2:46     ` KAMEZAWA Hiroyuki
2008-11-08  5:00     ` Badari Pulavarty [this message]
2008-11-08  5:00       ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49151CFF.8060503@us.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=balbir@in.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.