* [PATCH] kvm: ensure that memslot userspace addresses are page-aligned
@ 2008-11-07 19:32 ` Hollis Blanchard
0 siblings, 0 replies; 4+ messages in thread
From: Hollis Blanchard @ 2008-11-07 19:32 UTC (permalink / raw)
To: avi-H+wXaHxf7aLQT0dZR+AlfA
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA, kvm-u79uwXL29TY76Z2rM5mHXA
Bad page translation and silent guest failure ensue if the userspace address is
not page-aligned. I hit this problem using large (host) pages with qemu,
because qemu currently has a hardcoded 4096-byte alignment for guest memory
allocations.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -714,6 +714,8 @@ int __kvm_set_memory_region(struct kvm *
if (mem->memory_size & (PAGE_SIZE - 1))
goto out;
if (mem->guest_phys_addr & (PAGE_SIZE - 1))
+ goto out;
+ if (mem->userspace_addr & (PAGE_SIZE - 1))
goto out;
if (mem->slot >= KVM_MEMORY_SLOTS + KVM_PRIVATE_MEM_SLOTS)
goto out;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] kvm: ensure that memslot userspace addresses are page-aligned
@ 2008-11-07 19:32 ` Hollis Blanchard
0 siblings, 0 replies; 4+ messages in thread
From: Hollis Blanchard @ 2008-11-07 19:32 UTC (permalink / raw)
To: avi-H+wXaHxf7aLQT0dZR+AlfA
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA, kvm-u79uwXL29TY76Z2rM5mHXA
Bad page translation and silent guest failure ensue if the userspace address is
not page-aligned. I hit this problem using large (host) pages with qemu,
because qemu currently has a hardcoded 4096-byte alignment for guest memory
allocations.
Signed-off-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -714,6 +714,8 @@ int __kvm_set_memory_region(struct kvm *
if (mem->memory_size & (PAGE_SIZE - 1))
goto out;
if (mem->guest_phys_addr & (PAGE_SIZE - 1))
+ goto out;
+ if (mem->userspace_addr & (PAGE_SIZE - 1))
goto out;
if (mem->slot >= KVM_MEMORY_SLOTS + KVM_PRIVATE_MEM_SLOTS)
goto out;
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <76e29eef35b1442b4150.1226086332-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>]
* Re: [PATCH] kvm: ensure that memslot userspace addresses are page-aligned
[not found] ` <76e29eef35b1442b4150.1226086332-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
@ 2008-11-09 10:01 ` Avi Kivity
0 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2008-11-09 10:01 UTC (permalink / raw)
To: Hollis Blanchard
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA, kvm-u79uwXL29TY76Z2rM5mHXA
Hollis Blanchard wrote:
> Bad page translation and silent guest failure ensue if the userspace address is
> not page-aligned. I hit this problem using large (host) pages with qemu,
> because qemu currently has a hardcoded 4096-byte alignment for guest memory
> allocations.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: ensure that memslot userspace addresses are page-aligned
@ 2008-11-09 10:01 ` Avi Kivity
0 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2008-11-09 10:01 UTC (permalink / raw)
To: Hollis Blanchard
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA, kvm-u79uwXL29TY76Z2rM5mHXA
Hollis Blanchard wrote:
> Bad page translation and silent guest failure ensue if the userspace address is
> not page-aligned. I hit this problem using large (host) pages with qemu,
> because qemu currently has a hardcoded 4096-byte alignment for guest memory
> allocations.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-09 10:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-07 19:32 [PATCH] kvm: ensure that memslot userspace addresses are page-aligned Hollis Blanchard
2008-11-07 19:32 ` Hollis Blanchard
[not found] ` <76e29eef35b1442b4150.1226086332-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-09 10:01 ` Avi Kivity
2008-11-09 10:01 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.