From: Avi Kivity <avi@redhat.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] kvm: ppc: fix Kconfig constraints
Date: Sun, 09 Nov 2008 10:05:02 +0000 [thread overview]
Message-ID: <4916B5CE.1080605@redhat.com> (raw)
In-Reply-To: <1226085313.9309.26.camel@localhost.localdomain>
Hollis Blanchard wrote:
> kvm: ppc: fix Kconfig constraints
>
> Make sure that CONFIG_KVM cannot be selected without processor support
> (currently, 440 is the only processor implementation available).
>
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
>
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -15,24 +15,22 @@ if VIRTUALIZATION
> if VIRTUALIZATION
>
> config KVM
> - bool "Kernel-based Virtual Machine (KVM) support"
> - depends on EXPERIMENTAL
> + bool
> select PREEMPT_NOTIFIERS
> select ANON_INODES
> +
> +config KVM_440
> + bool "KVM support for PowerPC 440 processors"
> + depends on EXPERIMENTAL && 44x
> + select KVM
>
I have a vague memory that 'select' will not propagate (what's the word?
transitive?) - -that is, the 'select KVM' will enable KVM but will not
cause ANON_INODES and PREEMPT_NOTIFIERS to be set.
Can you check this out?
(copying Sam for a definitive statement)
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] kvm: ppc: fix Kconfig constraints
Date: Sun, 09 Nov 2008 12:05:02 +0200 [thread overview]
Message-ID: <4916B5CE.1080605@redhat.com> (raw)
In-Reply-To: <1226085313.9309.26.camel@localhost.localdomain>
Hollis Blanchard wrote:
> kvm: ppc: fix Kconfig constraints
>
> Make sure that CONFIG_KVM cannot be selected without processor support
> (currently, 440 is the only processor implementation available).
>
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
>
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -15,24 +15,22 @@ if VIRTUALIZATION
> if VIRTUALIZATION
>
> config KVM
> - bool "Kernel-based Virtual Machine (KVM) support"
> - depends on EXPERIMENTAL
> + bool
> select PREEMPT_NOTIFIERS
> select ANON_INODES
> +
> +config KVM_440
> + bool "KVM support for PowerPC 440 processors"
> + depends on EXPERIMENTAL && 44x
> + select KVM
>
I have a vague memory that 'select' will not propagate (what's the word?
transitive?) - -that is, the 'select KVM' will enable KVM but will not
cause ANON_INODES and PREEMPT_NOTIFIERS to be set.
Can you check this out?
(copying Sam for a definitive statement)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-09 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 19:10 [PATCH] kvm: ppc: fix Kconfig constraints Hollis Blanchard
2008-11-07 19:10 ` Hollis Blanchard
2008-11-07 19:15 ` Hollis Blanchard
2008-11-07 19:15 ` Hollis Blanchard
2008-11-09 10:05 ` Avi Kivity [this message]
2008-11-09 10:05 ` Avi Kivity
[not found] ` <4916B5CE.1080605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-11-09 15:43 ` Sam Ravnborg
2008-11-09 15:43 ` Sam Ravnborg
2008-11-09 15:48 ` Avi Kivity
2008-11-09 15:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4916B5CE.1080605@redhat.com \
--to=avi@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.