From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v4)
Date: Mon, 17 Nov 2008 10:19:59 +0530 [thread overview]
Message-ID: <4920F7F7.6050601@linux.vnet.ibm.com> (raw)
In-Reply-To: <4920F70D.9030100@cn.fujitsu.com>
Li Zefan wrote:
>> + /*
>> + * If parent's use_hiearchy is set, we can't make any modifications
>> + * in the child subtrees. If it is unset, then the change can
>> + * occur, provided the current cgroup has no children.
>> + *
>> + * For the root cgroup, parent_mem is NULL, we allow value to be
>> + * set if there are no children.
>> + */
>> + if (!parent_mem || (!parent_mem->use_hierarchy &&
>> + (val == 1 || val == 0))) {
>
> Should be :
>
> if ((!parent_mem || !parent_mem->use_hierarchy) &&
> (val == 1 || val == 0)) {
Yes, we need to validate values for root cgroup as well. Thanks for the comments
--
Balbir
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-mm@kvack.org, YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Rientjes <rientjes@google.com>,
Pavel Emelianov <xemul@openvz.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v4)
Date: Mon, 17 Nov 2008 10:19:59 +0530 [thread overview]
Message-ID: <4920F7F7.6050601@linux.vnet.ibm.com> (raw)
In-Reply-To: <4920F70D.9030100@cn.fujitsu.com>
Li Zefan wrote:
>> + /*
>> + * If parent's use_hiearchy is set, we can't make any modifications
>> + * in the child subtrees. If it is unset, then the change can
>> + * occur, provided the current cgroup has no children.
>> + *
>> + * For the root cgroup, parent_mem is NULL, we allow value to be
>> + * set if there are no children.
>> + */
>> + if (!parent_mem || (!parent_mem->use_hierarchy &&
>> + (val == 1 || val == 0))) {
>
> Should be :
>
> if ((!parent_mem || !parent_mem->use_hierarchy) &&
> (val == 1 || val == 0)) {
Yes, we need to validate values for root cgroup as well. Thanks for the comments
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-17 4:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 8:10 [mm][PATCH 0/4] Memory cgroup hierarchy introduction (v4) Balbir Singh
2008-11-16 8:10 ` Balbir Singh
2008-11-16 8:10 ` [mm] [PATCH 1/4] Memory cgroup hierarchy documentation (v4) Balbir Singh
2008-11-16 8:10 ` Balbir Singh
2008-11-17 1:06 ` Li Zefan
2008-11-17 1:06 ` Li Zefan
2008-11-17 3:37 ` Balbir Singh
2008-11-17 3:37 ` Balbir Singh
2008-11-16 8:10 ` [mm] [PATCH 2/4] Memory cgroup resource counters for hierarchy (v4) Balbir Singh
2008-11-16 8:10 ` Balbir Singh
2008-11-16 8:10 ` [mm] [PATCH 3/4] Memory cgroup hierarchical reclaim (v4) Balbir Singh
2008-11-16 8:10 ` Balbir Singh
2008-11-25 11:58 ` Daisuke Nishimura
2008-11-25 11:58 ` Daisuke Nishimura
2008-11-25 15:01 ` Balbir Singh
2008-11-25 15:01 ` Balbir Singh
2008-11-26 2:14 ` Daisuke Nishimura
2008-11-26 2:14 ` Daisuke Nishimura
2008-12-09 2:59 ` KAMEZAWA Hiroyuki
2008-12-09 2:59 ` KAMEZAWA Hiroyuki
2008-12-09 3:48 ` Balbir Singh
2008-12-09 3:48 ` Balbir Singh
2008-12-09 3:57 ` KAMEZAWA Hiroyuki
2008-12-09 3:57 ` KAMEZAWA Hiroyuki
2008-12-09 3:53 ` Daisuke Nishimura
2008-12-09 3:53 ` Daisuke Nishimura
2008-12-09 3:58 ` KAMEZAWA Hiroyuki
2008-12-09 3:58 ` KAMEZAWA Hiroyuki
2008-11-16 8:11 ` [mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v4) Balbir Singh
2008-11-16 8:11 ` Balbir Singh
2008-11-17 4:46 ` Li Zefan
2008-11-17 4:46 ` Li Zefan
2008-11-17 4:49 ` Balbir Singh [this message]
2008-11-17 4:49 ` Balbir Singh
2008-11-18 23:28 ` Andrew Morton
2008-11-18 23:28 ` Andrew Morton
2008-11-19 5:04 ` Balbir Singh
2008-11-19 5:04 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4920F7F7.6050601@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rientjes@google.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.