All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Support always running TSC on Intel CPUs
Date: Mon, 17 Nov 2008 17:07:26 -0800	[thread overview]
Message-ID: <4922154E.4050108@zytor.com> (raw)
In-Reply-To: <20081118010528.GA22044@linux-os.sc.intel.com>

Venki Pallipadi wrote:
>>>
>> I was under the impression that C2 was invoked by the chipset on a
>> thermal condition, at least on older (P3-era) processors.  Is that no
>> longer true?  If what you say is above (HLT and MWAIT only), then *was*
>> it ever true?
> 
> I should also add io port based C-state to HLT and MWAIT. But, that again is
> OS initiated.
> 
> I don't know of C2 invocation in thermal condition. Thermal condition, all
> CPUs that I know of (P3 and beyond), use either clock modulation or frequency
> changes. And on some such CPUs, where TSC runs at constant freq during such
> modulation/freq change, we set CONSTANT_TSC bit based on model number check.
> So, on CPUs earlier than those, we cannot use TSC or we have to scale TSC
> based on freq. This patch shouldn't have any impact for those CPUs.
> 

I believe there are CPUs -- again, in the P3-era range at least -- which 
invoke C2 from the chipset on thermal conditions (and basically PWM the 
CPU.)  I'd like to get that clarified so we don't trip up on that.

	-hpa


  reply	other threads:[~2008-11-18  1:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18  0:11 [PATCH] x86: Support always running TSC on Intel CPUs Venki Pallipadi
2008-11-18  0:13 ` H. Peter Anvin
2008-11-18  0:16   ` Pallipadi, Venkatesh
2008-11-18  0:18     ` H. Peter Anvin
2008-11-18  0:49       ` Venki Pallipadi
2008-11-18  0:52         ` H. Peter Anvin
2008-11-18  1:05           ` Venki Pallipadi
2008-11-18  1:07             ` H. Peter Anvin [this message]
2008-11-18  3:26               ` Arjan van de Ven
2008-11-18  3:27                 ` H. Peter Anvin
2008-11-18  8:09 ` Ingo Molnar
2008-11-18 14:55   ` Joe Korty
2008-11-18 16:05     ` Ingo Molnar
2008-11-18 16:47       ` Pallipadi, Venkatesh
2008-11-18 16:54         ` Joe Korty
2008-11-18 17:01         ` H. Peter Anvin
2008-11-18 16:48       ` Joe Korty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4922154E.4050108@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.