From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence
Date: Tue, 18 Nov 2008 11:41:09 +0900 [thread overview]
Message-ID: <49222B45.2070300@necel.com> (raw)
In-Reply-To: <200811171456.13382.sr@denx.de>
Stefan Roese wrote:
>> This is ok. I don't know why people prefers alias, though :-)
>
> Just because we don't need the ugly #ifdef's by using weak aliases. It has
> some drawbacks of course but in general the resulting source code
> looks "cleaner".
I was being vague. I prefers something like below, because I don't want
to have a dummy & empty function just for the `alias'.
int __attribute__((weak)) board_early_init_f(void)
{
return 0;
}
But that's not a big deal. Using weak function is ok, of course. Sorry
for the noise.
Thanks,
--
Shinya Kuribayashi
NEC Electronics
next prev parent reply other threads:[~2008-11-18 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 12:18 [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence Stefan Roese
2008-11-16 7:01 ` Shinya Kuribayashi
2008-11-17 13:56 ` Stefan Roese
2008-11-18 2:41 ` Shinya Kuribayashi [this message]
2008-11-17 14:14 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 15:00 ` Shinya Kuribayashi
2008-11-18 15:56 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49222B45.2070300@necel.com \
--to=shinya.kuribayashi@necel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.