From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence
Date: Wed, 19 Nov 2008 00:00:47 +0900 [thread overview]
Message-ID: <4922D89F.5030708@ruby.dti.ne.jp> (raw)
In-Reply-To: <20081117141419.GF9160@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:18 Wed 12 Nov , Stefan Roese wrote:
>> diff --git a/lib_mips/board.c b/lib_mips/board.c
>> index 77e1cc8..01dda69 100644
>> --- a/lib_mips/board.c
>> +++ b/lib_mips/board.c
>> @@ -70,6 +70,15 @@ static ulong mem_malloc_brk;
>> */
>> unsigned long mips_io_port_base = -1;
>>
>> +int __board_early_init_f(void)
>> +{
>> + /*
>> + * Nothing to do in this dummy implementation
>> + */
>> + return 0;
>> +}
> why not remove this and create a generic dummy function
>
> to reduce to code size impact
+1. Such dummy function could be shared among all architectures.
Thanks,
Shinya
next prev parent reply other threads:[~2008-11-18 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 12:18 [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence Stefan Roese
2008-11-16 7:01 ` Shinya Kuribayashi
2008-11-17 13:56 ` Stefan Roese
2008-11-18 2:41 ` Shinya Kuribayashi
2008-11-17 14:14 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 15:00 ` Shinya Kuribayashi [this message]
2008-11-18 15:56 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4922D89F.5030708@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.