From: <zrzeng@sohu.com>
To: <netfilter-devel@lists.netfilter.org>
Subject: nf_reinject() buggy?
Date: Tue, 20 Jan 2004 09:37:14 +0800 (CST) [thread overview]
Message-ID: <4926736.1074562635922.JavaMail.postfix@mx16.mail.sohu.com> (raw)
in nf_reinject(), we have
void nf_reinject(struct sk_buff *skb, struct nf_info *info,
unsigned int verdict)
{
struct list_head *elem = &info->elem->list;
struct list_head *i;
......
list_for_each_rcu(i, &nf_hooks[info->pf][info->hook]) {
if (i == elem)
break;
}
---> if (elem == &nf_hooks[info->pf][info->hook]) {
/* The module which sent it to userspace is gone. */
NFDEBUG("%s: module disappeared, dropping packet.\n",
__FUNCTION__);
verdict = NF_DROP;
}
......
}
I think the statement tagged "--->" should be
if (i == &nf_hooks[info->pf][info->hook]) {
Am I right?
regards
reply other threads:[~2004-01-20 1:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4926736.1074562635922.JavaMail.postfix@mx16.mail.sohu.com \
--to=zrzeng@sohu.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.