All of lore.kernel.org
 help / color / mirror / Atom feed
* nf_reinject() buggy?
@ 2004-01-20  1:37 zrzeng
  0 siblings, 0 replies; only message in thread
From: zrzeng @ 2004-01-20  1:37 UTC (permalink / raw)
  To: netfilter-devel

in nf_reinject(), we have

void nf_reinject(struct sk_buff *skb, struct nf_info *info,
		 unsigned int verdict)
{
	struct list_head *elem = &info->elem->list;
	struct list_head *i;

           ......

	list_for_each_rcu(i, &nf_hooks[info->pf][info->hook]) {
		if (i == elem) 
  			break;
  	}
  
--->	if (elem == &nf_hooks[info->pf][info->hook]) {
		/* The module which sent it to userspace is gone. */
		NFDEBUG("%s: module disappeared, dropping packet.\n",
			__FUNCTION__);
		verdict = NF_DROP;
	}

          ......
}

I think the statement tagged "--->" should be 

           if (i == &nf_hooks[info->pf][info->hook]) {

Am I right?

regards

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-01-20  1:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-20  1:37 nf_reinject() buggy? zrzeng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.