All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Sheng Yang <sheng@linux.intel.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Make QEmu depends on libpci
Date: Fri, 21 Nov 2008 08:10:59 -0600	[thread overview]
Message-ID: <4926C173.3090408@codemonkey.ws> (raw)
In-Reply-To: <1227274886-23459-1-git-send-email-sheng@linux.intel.com>

Sheng Yang wrote:
> libpci is handy to handle some pci device related things.
>
> This is the same as first patch I sent in MSI userspace patchset in kvm
> mailing list, and this one is based on QEmu upstream.
>   

It should be an optional dependency.  If libpci isn't present, then you 
should disable PCI passthrough.  See the checks for gnutls, libvde, 
bluez, etc.

Regards,

Anthony LIguori

> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  Makefile.target |    2 +-
>  configure       |   19 +++++++++++++++++++
>  2 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 3cdf7db..7cf5b00 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -598,7 +598,7 @@ else
>  OBJS+=block-raw-posix.o
>  endif
>  
> -LIBS+=-lz
> +LIBS+=-lz -lpci
>  ifdef CONFIG_ALSA
>  LIBS += -lasound
>  endif
> diff --git a/configure b/configure
> index 1f3d233..1f35e3d 100755
> --- a/configure
> +++ b/configure
> @@ -764,6 +764,25 @@ else
>  fi
>  
>  ##########################################
> +# libpci probe
> +cat > $TMPC << EOF
> +#include <pci/pci.h>
> +#ifndef PCI_VENDOR_ID
> +#error NO LIBPCI
> +#endif
> +int main(void) { return 0; }
> +EOF
> +if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC 2>/dev/null ; then
> +    :
> +else
> +    echo
> +    echo "Error: libpci check failed"
> +    echo "Make sure to have the libpci libs and headers installed."
> +    echo
> +    exit 1
> +fi
> +
> +##########################################
>  # SDL probe
>  
>  sdl_too_old=no
>   


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Sheng Yang <sheng@linux.intel.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] Make QEmu depends on libpci
Date: Fri, 21 Nov 2008 08:10:59 -0600	[thread overview]
Message-ID: <4926C173.3090408@codemonkey.ws> (raw)
In-Reply-To: <1227274886-23459-1-git-send-email-sheng@linux.intel.com>

Sheng Yang wrote:
> libpci is handy to handle some pci device related things.
>
> This is the same as first patch I sent in MSI userspace patchset in kvm
> mailing list, and this one is based on QEmu upstream.
>   

It should be an optional dependency.  If libpci isn't present, then you 
should disable PCI passthrough.  See the checks for gnutls, libvde, 
bluez, etc.

Regards,

Anthony LIguori

> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  Makefile.target |    2 +-
>  configure       |   19 +++++++++++++++++++
>  2 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 3cdf7db..7cf5b00 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -598,7 +598,7 @@ else
>  OBJS+=block-raw-posix.o
>  endif
>  
> -LIBS+=-lz
> +LIBS+=-lz -lpci
>  ifdef CONFIG_ALSA
>  LIBS += -lasound
>  endif
> diff --git a/configure b/configure
> index 1f3d233..1f35e3d 100755
> --- a/configure
> +++ b/configure
> @@ -764,6 +764,25 @@ else
>  fi
>  
>  ##########################################
> +# libpci probe
> +cat > $TMPC << EOF
> +#include <pci/pci.h>
> +#ifndef PCI_VENDOR_ID
> +#error NO LIBPCI
> +#endif
> +int main(void) { return 0; }
> +EOF
> +if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC 2>/dev/null ; then
> +    :
> +else
> +    echo
> +    echo "Error: libpci check failed"
> +    echo "Make sure to have the libpci libs and headers installed."
> +    echo
> +    exit 1
> +fi
> +
> +##########################################
>  # SDL probe
>  
>  sdl_too_old=no
>   

  reply	other threads:[~2008-11-21 14:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21 13:41 [PATCH] Make QEmu depends on libpci Sheng Yang
2008-11-21 13:41 ` [Qemu-devel] " Sheng Yang
2008-11-21 14:10 ` Anthony Liguori [this message]
2008-11-21 14:10   ` [Qemu-devel] " Anthony Liguori
2008-11-21 14:09   ` Sheng Yang
2008-11-21 14:09     ` [Qemu-devel] " Sheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4926C173.3090408@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.