* iwlwifi produces "Can not allocate SKB buffers"
@ 2008-11-21 15:04 Marcel Holtmann
0 siblings, 0 replies; only message in thread
From: Marcel Holtmann @ 2008-11-21 15:04 UTC (permalink / raw)
To: linux-wireless
Hi guys,
after the DMA issues got fixed, I am still seeing the SKB allocation
errors. So I put a WARN() into the code:
diff --git a/drivers/net/wireless/iwlwifi/iwl-rx.c
b/drivers/net/wireless/iwlwifi/iwl-rx.c
index 8d2b73e..acd9b12 100644
--- a/drivers/net/wireless/iwlwifi/iwl-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
@@ -252,10 +252,7 @@ void iwl_rx_allocate(struct iwl_priv *priv)
/* Alloc a new receive buffer */
rxb->skb = alloc_skb(priv->hw_params.rx_buf_size + 256,
__GFP_NOWARN | GFP_ATOMIC);
- if (!rxb->skb) {
- if (net_ratelimit())
- printk(KERN_CRIT DRV_NAME
- ": Can not allocate SKB buffers\n");
+ if (WARN(!rxb->skb, "Can not allocate SKB buffers\n")) {
/* We don't reschedule replenish work here -- we
will
* call the restock method and if it still needs
* more buffers it will schedule replenish */
This allows me to record these issue via kerneloops.org. And here is one
from my current wireless-testing tree I am running:
http://www.kerneloops.org/raw.php?rawid=104543&msgid=
Regards
Marcel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-11-21 14:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-21 15:04 iwlwifi produces "Can not allocate SKB buffers" Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.