All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gianluca Guida <gianluca.guida@eu.citrix.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Re: issues with movnti emulation
Date: Tue, 25 Nov 2008 14:01:28 +0000	[thread overview]
Message-ID: <492C0538.9030702@eu.citrix.com> (raw)
In-Reply-To: <C54B4B1D.1F707%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> I think the issue is that I did a bad backport to 3.3. The 'case 0xc3'
> should be under twobyte_special_insn rather than twobyte_insn, right? The
> two separate paths got merged into one in xen-unstable.

This seems actually to be the case. The actual move from src.val to 
dst.val never happened with the current patch, and this made movnti to 
write in memory the original dst.val value, leading to memory corruption.

By moving the switch case into twobyte_insn the problem goes away.

Gianluca

      parent reply	other threads:[~2008-11-25 14:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20 16:38 issues with movnti emulation Jan Beulich
2008-11-20 17:13 ` Keir Fraser
2008-11-20 17:16   ` Tim Deegan
2008-11-20 17:43     ` Keir Fraser
2008-11-21 16:01       ` Tim Deegan
2008-11-24 16:18         ` Gianluca Guida
2008-11-24 15:34           ` Jan Beulich
2008-11-20 18:42   ` Kevin Wolf
2008-11-21 11:04   ` Jan Beulich
2008-11-21 11:19     ` Keir Fraser
2008-11-25 14:01   ` Gianluca Guida [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=492C0538.9030702@eu.citrix.com \
    --to=gianluca.guida@eu.citrix.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.