From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: MMU: optimize set_spte for page sync
Date: Tue, 25 Nov 2008 16:38:13 +0200 [thread overview]
Message-ID: <492C0DD5.7070206@redhat.com> (raw)
In-Reply-To: <20081124132306.GA13532@dmt.cnet>
Marcelo Tosatti wrote:
> *shadow_pte can point to a different page if the guest updates
> pagetable, there is a fault before resync, the fault updates the
> spte with new gfn (and pfn) via mmu_set_spte. In which case the gfn
> cache is updated since:
>
> } else if (pfn != spte_to_pfn(*shadow_pte)) {
> printk("hfn old %lx new %lx\n",
> spte_to_pfn(*shadow_pte), pfn);
> rmap_remove(vcpu->kvm, shadow_pte);
>
Okay. Please resend but without the reversal of can_unsync, it will
make a more readable patch. If you like, send a follow on that only
does the reversal.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-25 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 18:49 KVM: MMU: optimize set_spte for page sync Marcelo Tosatti
2008-11-23 10:36 ` Avi Kivity
2008-11-24 12:04 ` Marcelo Tosatti
2008-11-24 13:23 ` Marcelo Tosatti
2008-11-25 14:38 ` Avi Kivity [this message]
2008-11-25 14:58 ` Marcelo Tosatti
2008-11-26 11:12 ` Avi Kivity
2008-12-09 15:52 ` Marcelo Tosatti
2008-12-10 9:14 ` Avi Kivity
2008-12-10 12:54 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492C0DD5.7070206@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.