From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: MMU: optimize set_spte for page sync
Date: Wed, 26 Nov 2008 13:12:20 +0200 [thread overview]
Message-ID: <492D2F14.2070705@redhat.com> (raw)
In-Reply-To: <20081125145807.GA14994@dmt.cnet>
Marcelo Tosatti wrote:
>
> Here it goes.
>
> KVM: MMU: optimize set_spte for page sync
>
> The write protect verification in set_spte is unnecessary for page sync.
>
> Its guaranteed that, if the unsync spte was writable, the target page
> does not have a write protected shadow (if it had, the spte would have
> been write protected under mmu_lock by rmap_write_protect before).
>
> Same reasoning applies to mark_page_dirty: the gfn has been marked as
> dirty via the pagefault path.
>
> The cost of hash table and memslot lookups are quite significant if the
> workload is pagetable write intensive resulting in increased mmu_lock
> contention.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-11-26 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 18:49 KVM: MMU: optimize set_spte for page sync Marcelo Tosatti
2008-11-23 10:36 ` Avi Kivity
2008-11-24 12:04 ` Marcelo Tosatti
2008-11-24 13:23 ` Marcelo Tosatti
2008-11-25 14:38 ` Avi Kivity
2008-11-25 14:58 ` Marcelo Tosatti
2008-11-26 11:12 ` Avi Kivity [this message]
2008-12-09 15:52 ` Marcelo Tosatti
2008-12-10 9:14 ` Avi Kivity
2008-12-10 12:54 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492D2F14.2070705@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.