Re: [PATCH] Add KVM version to monitor "info version"

[Avi Kivity <avi@redhat.com>]

Glauber Costa wrote:
> On Wed, Nov 26, 2008 at 8:55 AM, Daniel P. Berrange <berrange@redhat.com> wrote:
>   
>> On Wed, Nov 26, 2008 at 11:22:03AM +0100, Bj?rn Mork wrote:
>>     
>>> Trying to track the current KVM head as closely as possible, I often
>>> find myself wondering which KVM version a particular guest instance is
>>> running.  The attached patch adds this information to the monitor
>>> command "info version":
>>>
>>>  (qemu) info version
>>>  0.9.1 (kvm-79)
>>>       
>> I'd really rather we didn't touch the 'info version' command since it
>> means we have different syntax from upstream QEMU. If we want KVM
>> version info exposed, then I'd suggest 'info kvmversion' or some other
>> new command.
>>     
>
> I believe it fits nicely into info kvm. Instead of enabled/disabled,
> we could answer
> disabled or kvm-whatever
>
>   

(qemu) info kvm
enabled (kvm-123)

or

(qemu) info kvm
enabled
version kvm-123

May be easier to parse, and more backwards compatible.

-- 
error compiling committee.c: too many arguments to function