* Reiser4: remove simple_prepare_write usage
@ 2008-11-26 17:05 Laurent Riffard
2008-11-26 17:51 ` Randy Dunlap
2008-11-26 17:57 ` Edward Shishkin
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Riffard @ 2008-11-26 17:05 UTC (permalink / raw)
To: ReiserFS Mailing List, Edward Shishkin; +Cc: Andrew Morton, Randy Dunlap
Reiser4 can't be built as a module when EXPORT_UNUSED_SYMBOL is not set.
It's broken because reiser4_write_extent is calling
simple_prepare_write() and commit
4e02ed4b4a2fae34aae766a5bb93ae235f60adb8 scheduled it for unexporting.
Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
---
fs/reiser4/plugin/item/extent_file_ops.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/reiser4/plugin/item/extent_file_ops.c b/fs/reiser4/plugin/item/extent_file_ops.c
index ef3744e..1eb1ab7 100644
--- a/fs/reiser4/plugin/item/extent_file_ops.c
+++ b/fs/reiser4/plugin/item/extent_file_ops.c
@@ -1059,8 +1059,9 @@ ssize_t reiser4_write_extent(struct file *file, struct inode * inode,
lock_page(page);
if (!PageUptodate(page) && to_page != PAGE_CACHE_SIZE)
- simple_prepare_write(file, page, page_off,
- page_off + to_page);
+ zero_user_segments(page, 0, page_off,
+ page_off + to_page,
+ PAGE_CACHE_SIZE);
written = filemap_copy_from_user(page, page_off, buf, to_page);
if (unlikely(written != to_page)) {
--
1.6.0.4.3.g5bcce
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Reiser4: remove simple_prepare_write usage
2008-11-26 17:05 Reiser4: remove simple_prepare_write usage Laurent Riffard
@ 2008-11-26 17:51 ` Randy Dunlap
2008-11-26 17:57 ` Edward Shishkin
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-11-26 17:51 UTC (permalink / raw)
To: Laurent Riffard; +Cc: ReiserFS Mailing List, Edward Shishkin, Andrew Morton
Laurent Riffard wrote:
> Reiser4 can't be built as a module when EXPORT_UNUSED_SYMBOL is not set.
>
> It's broken because reiser4_write_extent is calling
> simple_prepare_write() and commit
> 4e02ed4b4a2fae34aae766a5bb93ae235f60adb8 scheduled it for unexporting.
>
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
Builds successfully now. Thanks.
> ---
> fs/reiser4/plugin/item/extent_file_ops.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/reiser4/plugin/item/extent_file_ops.c b/fs/reiser4/plugin/item/extent_file_ops.c
> index ef3744e..1eb1ab7 100644
> --- a/fs/reiser4/plugin/item/extent_file_ops.c
> +++ b/fs/reiser4/plugin/item/extent_file_ops.c
> @@ -1059,8 +1059,9 @@ ssize_t reiser4_write_extent(struct file *file, struct inode * inode,
>
> lock_page(page);
> if (!PageUptodate(page) && to_page != PAGE_CACHE_SIZE)
> - simple_prepare_write(file, page, page_off,
> - page_off + to_page);
> + zero_user_segments(page, 0, page_off,
> + page_off + to_page,
> + PAGE_CACHE_SIZE);
>
> written = filemap_copy_from_user(page, page_off, buf, to_page);
> if (unlikely(written != to_page)) {
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Reiser4: remove simple_prepare_write usage
2008-11-26 17:05 Reiser4: remove simple_prepare_write usage Laurent Riffard
2008-11-26 17:51 ` Randy Dunlap
@ 2008-11-26 17:57 ` Edward Shishkin
1 sibling, 0 replies; 3+ messages in thread
From: Edward Shishkin @ 2008-11-26 17:57 UTC (permalink / raw)
To: Laurent Riffard; +Cc: ReiserFS Mailing List, Andrew Morton, Randy Dunlap
Laurent Riffard wrote:
> Reiser4 can't be built as a module when EXPORT_UNUSED_SYMBOL is not set.
>
> It's broken because reiser4_write_extent is calling
> simple_prepare_write() and commit
> 4e02ed4b4a2fae34aae766a5bb93ae235f60adb8 scheduled it for unexporting.
>
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
>
Acked-by: Edward Shishkin <edward.shishkin@gmail.com>
> ---
> fs/reiser4/plugin/item/extent_file_ops.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/reiser4/plugin/item/extent_file_ops.c b/fs/reiser4/plugin/item/extent_file_ops.c
> index ef3744e..1eb1ab7 100644
> --- a/fs/reiser4/plugin/item/extent_file_ops.c
> +++ b/fs/reiser4/plugin/item/extent_file_ops.c
> @@ -1059,8 +1059,9 @@ ssize_t reiser4_write_extent(struct file *file, struct inode * inode,
>
> lock_page(page);
> if (!PageUptodate(page) && to_page != PAGE_CACHE_SIZE)
> - simple_prepare_write(file, page, page_off,
> - page_off + to_page);
> + zero_user_segments(page, 0, page_off,
> + page_off + to_page,
> + PAGE_CACHE_SIZE);
>
> written = filemap_copy_from_user(page, page_off, buf, to_page);
> if (unlikely(written != to_page)) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-26 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-26 17:05 Reiser4: remove simple_prepare_write usage Laurent Riffard
2008-11-26 17:51 ` Randy Dunlap
2008-11-26 17:57 ` Edward Shishkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.