[PATCH] tracing/branch-tracer: include missing irqflags.h

[PATCH] tracing/branch-tracer: include missing irqflags.h

[Frederic Weisbecker]

Impact: fix build error on branch tracer

This should fix a build error reported on alpha in linux-next:

 CC      kernel/trace/trace_branch.o
kernel/trace/trace_branch.c: In function 'probe_likely_condition':
kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'

Unfortunately, I can't test it since I don't have any Alpha build environment.

Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
index 877ee88..bc97275 100644
--- a/kernel/trace/trace_branch.c
+++ b/kernel/trace/trace_branch.c
@@ -6,6 +6,7 @@
 #include <linux/kallsyms.h>
 #include <linux/seq_file.h>
 #include <linux/spinlock.h>
+#include <linux/irqflags.h>
 #include <linux/debugfs.h>
 #include <linux/uaccess.h>
 #include <linux/module.h>

Re: [PATCH] tracing/branch-tracer: include missing irqflags.h

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Impact: fix build error on branch tracer
> 
> This should fix a build error reported on alpha in linux-next:
> 
>  CC      kernel/trace/trace_branch.o
> kernel/trace/trace_branch.c: In function 'probe_likely_condition':
> kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
> kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'

applied to tip/tracing

> Unfortunately, I can't test it since I don't have any Alpha build 
> environment.

it does not trigger with an Alpha defconfig - we do test that.

And the thing is, lockdep (which introduced irqflags tracing) has been 
introduced upstream two years ago - and Alpha still does not have it 
implemented. The architecture should be marked CONFIG_BROKEN if it 
continues to cause problems like this.

Alexey, you seem to be using and relying on the Alpha architecture, could 
you please have a shot at this and implement the missing irqflags 
infrastructure? Thanks,

	Ingo

Re: [PATCH] tracing/branch-tracer: include missing irqflags.h

[Alexey Dobriyan]

On Sat, Nov 29, 2008 at 10:16:47AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > Impact: fix build error on branch tracer
> > 
> > This should fix a build error reported on alpha in linux-next:
> > 
> >  CC      kernel/trace/trace_branch.o
> > kernel/trace/trace_branch.c: In function 'probe_likely_condition':
> > kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
> > kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'
> 
> applied to tip/tracing
> 
> > Unfortunately, I can't test it since I don't have any Alpha build 
> > environment.
> 
> it does not trigger with an Alpha defconfig - we do test that.
> 
> And the thing is, lockdep (which introduced irqflags tracing) has been 
> introduced upstream two years ago - and Alpha still does not have it 
> implemented. The architecture should be marked CONFIG_BROKEN if it 
> continues to cause problems like this.

Or people can, horror, cross-compile stuff in relevant configurations.

> Alexey, you seem to be using and relying on the Alpha architecture,

No, just alpha is first on the list ('a'), so nastygrams get sent first.

> could you please have a shot at this and implement the missing irqflags
> infrastructure?

Maybe. Should be interesting.

Re: [PATCH] tracing/branch-tracer: include missing irqflags.h

[Ingo Molnar]

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Sat, Nov 29, 2008 at 10:16:47AM +0100, Ingo Molnar wrote:
> > 
> > * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > 
> > > Impact: fix build error on branch tracer
> > > 
> > > This should fix a build error reported on alpha in linux-next:
> > > 
> > >  CC      kernel/trace/trace_branch.o
> > > kernel/trace/trace_branch.c: In function 'probe_likely_condition':
> > > kernel/trace/trace_branch.c:44: error: implicit declaration of function 'raw_local_irq_save'
> > > kernel/trace/trace_branch.c:76: error: implicit declaration of function 'raw_local_irq_restore'
> > 
> > applied to tip/tracing
> > 
> > > Unfortunately, I can't test it since I don't have any Alpha build 
> > > environment.
> > 
> > it does not trigger with an Alpha defconfig - we do test that.
> > 
> > And the thing is, lockdep (which introduced irqflags tracing) has 
> > been introduced upstream two years ago - and Alpha still does not 
> > have it implemented. The architecture should be marked CONFIG_BROKEN 
> > if it continues to cause problems like this.
> 
> Or people can, horror, cross-compile stuff in relevant configurations.

Alpha does not have ftrace enabled in its defconfig, so unless you define 
"relevant configurations" as "dozens and dozens of stupid configs nobody 
uses and that do not matter to 99.9% of the users" i dont see the point.

And the thing is, even if someone wanted to waste serious amount of time 
on crossbuilding to all architectures, a consistent set of crosscompilers 
is not readily available. They are not packaged up properly for distros 
and it's not clear which architecture wants what crosscompiler version 
and binutils setup.

Nor is it clear why kernel developers should slow down their testing 
critical path twenty fold (or more), while it's at most 3 architectures 
that really matter.

> > Alexey, you seem to be using and relying on the Alpha architecture,
> 
> No, just alpha is first on the list ('a'), so nastygrams get sent 
> first.

Basically via your "nastygrams" you are artificially inflating the 
importance of certain bugreports, well beyond their true importance. You 
are indirectly re-weighting and wasting developer resources that way.

It would be far more important and far more relevant to go over the lists 
on kerneloops.org, or over the bugs in bugzilla.kernel.org than to 
complain that some tree broke Alpha 'again'. Alpha is a stale 
architecture and it shows.

	Ingo