From: Avi Kivity <avi@redhat.com>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86 emulator: switch 'pop reg' instruction to emulate_pop()
Date: Sat, 29 Nov 2008 20:35:32 +0200 [thread overview]
Message-ID: <49318B74.7060209@redhat.com> (raw)
In-Reply-To: <20081128094747.432594c4@frecb000711>
Guillaume Thouvenin wrote:
> With this patch kvmctl ./user/test/x86/realmode.flat failed if
> emulate_invalid_guest_state is enabled. The error is:
>
> emulation failed (emulation failure) rip 99 66 2d 9a 01
>
> It seems that instruction pointer is wrong.
>
>
Yes, 'call' was using the pop_instruction path. I fixed it up.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2008-11-29 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081127194353.5E440A006D@cleopatra.tlv.redhat.com>
2008-11-28 8:47 ` [PATCH] KVM: x86 emulator: switch 'pop reg' instruction to emulate_pop() Guillaume Thouvenin
2008-11-29 18:35 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49318B74.7060209@redhat.com \
--to=avi@redhat.com \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.