* [PATCH] KVM: fix sparse warning
@ 2008-11-28 16:02 ` Hannes Eder
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Eder @ 2008-11-28 16:02 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
Impact: make global function static
virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
virt/kvm/kvm_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 54d25e6..8dab7ce 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -82,7 +82,7 @@ struct dentry *kvm_debugfs_dir;
static long kvm_vcpu_ioctl(struct file *file, unsigned int ioctl,
unsigned long arg);
-bool kvm_rebooting;
+static bool kvm_rebooting;
#ifdef KVM_CAP_DEVICE_ASSIGNMENT
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] KVM: fix sparse warning
@ 2008-11-28 16:02 ` Hannes Eder
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Eder @ 2008-11-28 16:02 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm, linux-kernel, kernel-janitors, trivial
Impact: make global function static
virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
virt/kvm/kvm_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 54d25e6..8dab7ce 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -82,7 +82,7 @@ struct dentry *kvm_debugfs_dir;
static long kvm_vcpu_ioctl(struct file *file, unsigned int ioctl,
unsigned long arg);
-bool kvm_rebooting;
+static bool kvm_rebooting;
#ifdef KVM_CAP_DEVICE_ASSIGNMENT
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: fix sparse warning
2008-11-28 16:02 ` Hannes Eder
@ 2008-11-30 10:17 ` Avi Kivity
-1 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2008-11-30 10:17 UTC (permalink / raw)
To: Hannes Eder; +Cc: kvm, linux-kernel, kernel-janitors, trivial
Hannes Eder wrote:
> Impact: make global function static
>
> virt/kvm/kvm_main.c:85:6: warning: symbol 'kvm_rebooting' was not declared. Should it be static?
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-30 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-28 16:02 [PATCH] KVM: fix sparse warning Hannes Eder
2008-11-28 16:02 ` Hannes Eder
2008-11-30 10:17 ` Avi Kivity
2008-11-30 10:17 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.