Re: [PATCH 3/4] KVM: gracefully handle zero in kvm_free_irq_source_id()

[Avi Kivity <avi@redhat.com>]

Mark McLoughlin wrote:
> Allow kvm_free_irq_source_id() to be called with a zero ID.
>
> Zero is reserved for KVM_USERSPACE_IRQ_SOURCE_ID, so we can
> guarantee that kvm_request_irq_source_id() will never return
> zero and use zero to indicate "no source ID allocated".
>
>   

Zero is a legal value for irq source ids, overloading it as something 
else is confusing.

Things should continue to work if we #define it to 17.

> +	}
> +
> +	ASSERT(irq_source_id != 0); /* KVM_USERSPACE_IRQ_SOURCE_ID reserved */
>   

Why not replace 0 with the actual symbolic constant?


-- 
error compiling committee.c: too many arguments to function